refactor(slots): Improve Slots Implementations#92
Merged
faustbrian merged 3 commits intoArkEcosystemArchive:masterfrom May 26, 2019
sleepdefic1t:refactor/improve-slot-implementations
Merged
refactor(slots): Improve Slots Implementations#92faustbrian merged 3 commits intoArkEcosystemArchive:masterfrom sleepdefic1t:refactor/improve-slot-implementations
faustbrian merged 3 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:refactor/improve-slot-implementations
Conversation
- Further decouple OS code from IoT code. - Add missing ESP8266 functionality. - Allow removal of lib/STL dependency. - STL lib is only included to provide a conv. method for IoT to use date.h - date.h is now only used by OS builds, which will have the STL by default. - update changelog. - add PIO filters for lib/date. -
Contributor
Author
|
additional passing tests @: |
Contributor
Author
|
@faustbrian |
3 tasks
faustbrian
approved these changes
May 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR improves the Slots implementations for OS & IoT builds.
As a result of this improvement and decoupling, an additional dependency is able to be removed.
Specifically, this PR does the following:
Types of changes
Checklist