Skip to content

chore: use correct field separator in keywords.txt#96

Merged
faustbrian merged 2 commits intoArkEcosystemArchive:developfrom
per1234:keywords-separator
May 31, 2019
Merged

chore: use correct field separator in keywords.txt#96
faustbrian merged 2 commits intoArkEcosystemArchive:developfrom
per1234:keywords-separator

Conversation

@per1234
Copy link
Contributor

@per1234 per1234 commented May 28, 2019

The Arduino IDE requires the use of a single true tab separator between the keyword name and identifier. When spaces are used rather than a true tab, the keyword is not highlighted.

Reference:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • [NA] All tests are passing
  • [NA] New/updated tests are included

If adding a new feature, the PR's description includes:

  • [NA] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@per1234
Use correct field separator in keywords.txt
ed15c0a 
The Arduino IDE requires the use of a single true tab separator between the keyword name and identifier. When spaces are used rather than a true tab, the keyword is not highlighted.

Reference:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords
@ghost
Copy link

ghost commented May 28, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label May 28, 2019
@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented May 29, 2019

Thank you, @per1234

This looks good to go, @faustbrian

@faustbrian faustbrian added the Bounty: Tier 5 Awarded for minor features, refactorings, improvements. This is valued at 0 USD. label May 31, 2019
@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label May 31, 2019
@ghost
Copy link

ghost commented May 31, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian changed the title Use correct field separator in keywords.txt chore: use correct field separator in keywords.txt May 31, 2019
@ghost
Copy link

ghost commented May 31, 2019

The ci/circleci: build-linux-gcc7 job is failing as of e024576f603fc8eac3b4ae6167a8dece8dd43fdc. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

1 similar comment
@ghost
Copy link

ghost commented May 31, 2019

The ci/circleci: build-linux-gcc7 job is failing as of e024576f603fc8eac3b4ae6167a8dece8dd43fdc. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit 899c1d0 into ArkEcosystemArchive:develop May 31, 2019
@ghost
Copy link

ghost commented May 31, 2019

Your pull request has been merged and marked as tier 5. It will earn you $5 USD.

@per1234 per1234 deleted the keywords-separator branch May 31, 2019 13:51
@boldninja
Copy link

boldninja commented Jun 2, 2019

@per1234 Can you provide me with your ARK address for GitHub bounty? You can also contact me on ARK's Slack - https://ark.io/slack (username : boldninja) and direct message me your address there.

@per1234
Copy link
Contributor Author

per1234 commented Jun 2, 2019

Here it is:
AV4qysF9vMnc5ujJmAQDKgDP8kFw3timVa

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

1 more reviewer

@faustbrian faustbrian faustbrian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bounty: Tier 5 Awarded for minor features, refactorings, improvements. This is valued at 0 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@per1234 @sleepdefic1t @boldninja @faustbrian