refactor: Use BIP66 Library#88
Merged
faustbrian merged 7 commits intoArkEcosystemArchive:masterfrom May 24, 2019
sleepdefic1t:chore/use-bip66-lib
Merged
refactor: Use BIP66 Library#88faustbrian merged 7 commits intoArkEcosystemArchive:masterfrom sleepdefic1t:chore/use-bip66-lib
faustbrian merged 7 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:chore/use-bip66-lib
Conversation
current DER encoding/decoding is built-in and lacks many improvements that are in the BIP66 lib. This PR drops the DER class, tests and usage in favor of the BIP66 library which is also a package in PlatformIO and the Arduino Library Manager.
|
The ci/circleci: build-linux-default job is failing as of 947882b92ed16431795357f817c7d7458d6a1b77. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Contributor
|
@sleepdefic1t is this ready? |
Contributor
Author
|
@faustbrian |
Contributor
Author
|
@faustbrian |
faustbrian
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
current DER encoding/decoding is built-in and lacks many improvements and proof against test-cases from BTC-BIP66 that are in the BIP66 lib.
This PR drops the DER class, tests and usage in favor of the BIP66 library which is also a package in PlatformIO and the Arduino Library Manager.
Types of changes
Checklist