fix: improve Windows support.#83
Merged
faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom May 21, 2019
sleepdefic1t:fix/improve-windows-support
Merged
fix: improve Windows support.#83faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom sleepdefic1t:fix/improve-windows-support
faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/improve-windows-support
Conversation
Windows doesn't handle dynamic allocation well. - transaction.cpp - explicitly define est. doc max size of 900. - No need for string since we're stating size. - message.cpp - let string handle doc size allocation.
|
The ci/circleci: build-linux-default job is failing as of a4021a71c09aa83ca5322a11c673036f791e3f76. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Current Windows builds fail with the following:
error C2131: expression did not evaluate to a constantThis is due to the way Windows handles dynamic allocation.
The current implementation uses this breaking allocation pattern in
transaction.cppandmessage.cpp.After the changes in this PR, Windows builds pass.
Types of changes
Checklist
Further comments
A later PR will address adding Appveyor support.