-
Notifications
You must be signed in to change notification settings - Fork 10
Description
Describe the bug
Builds fail with bip39 package on ESP8266, most recent at: #80
A PR has been sitting at packages main repo as a potential fix: ciband/bip39#8
There is a standing issue with repeating words in mnemonic generation brought up in #72
There are also imposed limitations on micro-architectural environments pertaining to library size due to its multi-language dictionary.
BIP39 is a nice feature to have, but this current implementation is buggy and out of scope for ARK SDK standards (ARK SDK Cryptography Guidelines).
I propose the bip39 lib be removed from the C++ Crypto SDK at this time.
Once its issues are addressed, I would like to see this listed as a C++ Crypto compatible lib in any relevant docs or media as an option for users; just not included by default.
Leaving this up for a few days to gather feedback if anyone wishes to weigh in.