fix(builder/transaction): Properly handle 0 ARKtoshi amount#80
Closed
sleepdefic1t wants to merge 23 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/zero-arktoshi
Closed
fix(builder/transaction): Properly handle 0 ARKtoshi amount#80sleepdefic1t wants to merge 23 commits intoArkEcosystemArchive:masterfrom sleepdefic1t:fix/zero-arktoshi
sleepdefic1t wants to merge 23 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/zero-arktoshi
Conversation
misc: merge from upstream
- list ArduinoJson as a dependency. - add Arduino sketch path to config. - fix the 'platformio_example' path.
This reverts commit 55d830b.
per #79 - 0 is already default amount for Transactions. - return empty/unvalidatable transaction if Transfer-type amount is not > 0. - add comments about > 0 ARKtoshi to Transaction::buildTransfer declaration. - add test for 0 ARKtoshi amount on Type-0 tx's.
|
The ci/circleci: build-linux-default job is failing as of 8cad465cf54f9ec0ddbc6796803c24b94cabb44d. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Contributor
Author
|
Build failure not a result of these changes. |
Contributor
Author
|
@faustbrian macOS failures are because CircleCI defaults my CI account, which is a free account (no macOS). linux-default/PlatformIO build fails due to BIP39 package issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR addresses #79 and adds additional checking to ensure that a 'Type-0'/Transfer Transaction amount is greater than 0 ARKtoshi.
Specifically, this PR does the following:
note: 0 is already default amount for Transactions, no additional changes were needed.
Types of changes
Checklist