Skip to content

fix: 0 ARKtoshi amount handling#85

Merged
faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/zero-arktoshi-handling
May 21, 2019
Merged

fix: 0 ARKtoshi amount handling#85
faustbrian merged 2 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/zero-arktoshi-handling

Conversation

@sleepdefic1t
Copy link
Contributor

@sleepdefic1t sleepdefic1t commented May 20, 2019

Proposed changes

This PR addresses #79 and adds additional checking to ensure that a 'Type-0'/Transfer Transaction amount is greater than 0 ARKtoshi.

This PR:

  • returns empty/unvalidatable transaction if Transfer-type amount is not > 0.
  • adds comments about > 0 ARKtoshi to Transaction::buildTransfer declaration.
  • adds test for 0 ARKtoshi amount on Type-0 tx's.

note: 0 is already default amount for Transactions, no additional changes were needed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels May 20, 2019
@ghost
Copy link

ghost commented May 20, 2019 •
edited by ghost
Loading

The ci/circleci: build-linux-default job is failing as of c4f15be244e5fd73fa8806a96147cdc6f06fb9e4. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t
Copy link
Contributor Author

sleepdefic1t commented May 21, 2019

build-linux-default/(PlatformIO) build failing as discussed in #81

@faustbrian faustbrian merged commit 4ea120b into ArkEcosystemArchive:master May 21, 2019
@sleepdefic1t sleepdefic1t mentioned this pull request May 21, 2019
Closed
@sleepdefic1t sleepdefic1t deleted the fix/zero-arktoshi-handling branch May 21, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees

No one assigned

Labels

Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sleepdefic1t @faustbrian