Skip to content

feat: Increase VendorField Size#84

Merged
faustbrian merged 3 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:chore/update-vendorfield-size
May 21, 2019
Merged

feat: Increase VendorField Size#84
faustbrian merged 3 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:chore/update-vendorfield-size

Conversation

@sleepdefic1t
Copy link
Contributor

@sleepdefic1t sleepdefic1t commented May 20, 2019

Proposed changes

This PR supports the change in vendorField size from 64 bytes to 255 bytes in Core v2.4.

Specifically:

  • transaction.cpp: update vendorField handling.
  • minor version bump
  • makes changelog current as of master + changes.

This also addresses #82

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels May 20, 2019
@ghost
Copy link

ghost commented May 20, 2019

The ci/circleci: build-linux-default job is failing as of e7c2a2c85f24da6510b839cd122c7ecf8a9edc2c. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t
Copy link
Contributor Author

build-linux-default/(PlatformIO) build failing as discussed in #81

@faustbrian faustbrian merged commit f88815a into ArkEcosystemArchive:master May 21, 2019
@sleepdefic1t sleepdefic1t deleted the chore/update-vendorfield-size branch May 21, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants