Skip to content

test: Use Core Fixtures#74

Merged
faustbrian merged 20 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:test/use-core-fixtures
Apr 16, 2019
Merged

test: Use Core Fixtures#74
faustbrian merged 20 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:test/use-core-fixtures

Conversation

@sleepdefic1t
Copy link
Contributor

Proposed changes

This PR updates all tests and examples to use test fixtures from ARK Core.

Specifically, this PR updates the following:

  • test/identities/address
  • test/identities/privatekey
  • test/identities/publickey
  • test/identities/wif
  • test/utils/message
  • examples/arduino/ESP32.ino
  • examples/arduino/ESP8266.ino
  • examples/platformio/main.ino

ARK Core Test Fixtures Source:

Types of changes

  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.
This PR updates all tests and examples to use test fixtures from ARK Core.

Specifically, this PR updates the following:
- identities/address
- identities/privatekey
- identities/publickey
- identities/wif
- utils/message
- examples/arduino/ESP32.ino
- examples/arduino/ESP8266.ino
- examples/platformio/main.ino

ARK Core Test Fixtures:
- https://github.com/ARKEcosystem/core/blob/develop/__tests__/unit/crypto/identities/fixture.json
- https://github.com/ARKEcosystem/core/blob/develop/__tests__/unit/crypto/utils/message.test.ts
@ghost ghost added Complexity: Medium Less than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. labels Apr 15, 2019
@ghost
Copy link

ghost commented Apr 15, 2019

The ci/circleci: build-linux-default job is failing as of 63a325d0bfc73afd08da185d2ad80fb3c0f68177. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t
Copy link
Contributor Author

ci/circleci: build-linux-default build failure is not a result of these changes.

This appears to be a package issue in PlatformIO involving ArduinoJson.

@faustbrian faustbrian merged commit d6f53e9 into ArkEcosystemArchive:master Apr 16, 2019
@sleepdefic1t sleepdefic1t deleted the test/use-core-fixtures branch May 13, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Less than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants