Skip to content

merge new master#5

Merged
webber26232 merged 100 commits intowebber26232:masterfrom
scikit-learn:master
May 11, 2020
Merged

merge new master#5
webber26232 merged 100 commits intowebber26232:masterfrom
scikit-learn:master

Conversation

@webber26232
Copy link
Copy Markdown
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

NicolasHug and others added 30 commits April 22, 2020 22:41
* API Deprecate positional arguments in random_projection

* CLN Address comments
* API Keyword only for semi_supervised

* CLN Address comments
* API Keyword only for svm

* BUG Fix

* CLN Address comments
* API Deprecate positional arguments in preprocessing

* CLN Address comments

* CLN Uses classes as a keyword only argument

* BUG Fix
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
ckastner and others added 29 commits May 3, 2020 23:30
* Remove sklearn logger default StreamHandler

To avoid duplicate log messages

* DOC Adds whats_new

* CLN Address comments

* MNT Remove setLevel

Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
* ENH Adjusts html_repr based on configuration

* CLN Returns None instead

* CLN Uses property hack

* CLN Address comments
* Added value checks and random state parameter to method

* Changed default parameter to None instead of 0

* Added numpy RandomState to the check

* Replaced inline validation with check_random_state from utils and pointed at glossery

* Needed a different default parameter to pass the default way this has been working in the past

* Updated to conform with flake8 stds

* Add random_state to AffinityPropagation class.

* Add test.

* Add what's new entry and versionadded directive.

* Add PR number.

* Fix lint error due to this PR.

* Use np.array_equal in test.

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Adrin Jalali <adrin.jalali@gmail.com>

* Homogenize parametre descriptions, default random_state to None.

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update sklearn/cluster/_affinity_propagation.py

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Update doc/whats_new/v0.23.rst

Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

* Change test name.

* Modify check in test.

* Fix lint errors.

* Address comment.

* Address comment.

* Add 'deprecation' and its correspondent test.

* Fix lint errors.

* Add random_state parameter to tests, to avoid FutureWarnings.

* Move warning in fit. Modify tests.

* Modify example.

* Tentative fix for failures.

* Document default value to 0. Revert docstring.

* Explicit link to Glossary.

* Fix default value.

* Remove some warnings from tests.

* Validate and test docstring.

* Tentative fix.

* Tentative fix.

* Ignore FutureWarning in fit attribute test.

* Set random_state to avoid FutureWarning in test_fit_docstring_attributes.

* [doc build] Force documentation build.

* Clarify warning message.

Co-authored-by: rwoolston.admin <rwoolston.admin@LXO-DS-DEV.afcucorp.local>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
* init

* flake8 error by vscode autoformatting

* remove returns

* get_model > get_estimator

* cosmit Tom + autoformat on save error again
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
* Fix documentation of default values in birch

* fix input and output description as suggested

* fix typo

Co-authored-by: Brigitte@home <unger@nue.tu-berlin.de>
Co-authored-by: Mateusz Górski <mateuszg122@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
@webber26232 webber26232 merged commit 8e2cf50 into webber26232:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.