API Deprecate positional arguments in semi_supervised module#16974
Merged
adrinjalali merged 3 commits intoscikit-learn:masterfrom Apr 22, 2020
Merged
API Deprecate positional arguments in semi_supervised module#16974adrinjalali merged 3 commits intoscikit-learn:masterfrom
adrinjalali merged 3 commits intoscikit-learn:masterfrom
Conversation
adrinjalali
approved these changes
Apr 21, 2020
Member
adrinjalali
left a comment
There was a problem hiding this comment.
I'm happy with this. @jnothman may want to have kernel positional?
Member
Author
|
Since |
Member
even then the name or signature of the callable would clearly mark it as a kernel. |
NicolasHug
approved these changes
Apr 22, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
I would agree with Joel that kernel could be positional
but LGTM anyway
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
…learn#16974) * API Keyword only for semi_supervised * CLN Address comments
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…learn#16974) * API Keyword only for semi_supervised * CLN Address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #15005