API Deprecate positional arguments in tree module#16966
Merged
NicolasHug merged 3 commits intoscikit-learn:masterfrom Apr 22, 2020
Merged
API Deprecate positional arguments in tree module#16966NicolasHug merged 3 commits intoscikit-learn:masterfrom
NicolasHug merged 3 commits intoscikit-learn:masterfrom
Conversation
adrinjalali
reviewed
Apr 20, 2020
Member
adrinjalali
left a comment
There was a problem hiding this comment.
LGTM, tests are failing due to internal positional usage.
adrinjalali
approved these changes
Apr 21, 2020
jnothman
approved these changes
Apr 21, 2020
Member
jnothman
left a comment
There was a problem hiding this comment.
Not sure if we should consider allowing positional criterion. They tend to be unambiguous.
Member
Author
|
I would prefer to make |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Toward #15005
What does this implement/fix? Explain your changes.
I am working backwards from the list.
CC @adrinjalali