[MRG] API kwonly for naive_bayes#17003
Merged
adrinjalali merged 2 commits intoscikit-learn:masterfrom Apr 24, 2020
Merged
Conversation
Member
Author
adrinjalali
reviewed
Apr 22, 2020
|
|
||
| def __init__(self, alpha=1.0, fit_prior=True, class_prior=None): | ||
| @_deprecate_positional_args | ||
| def __init__(self, *, alpha=1.0, fit_prior=True, class_prior=None): |
Member
There was a problem hiding this comment.
alpha is usually allowed positional in the rest of the library.
Member
|
-0 for keeping alpha positional. I don't think it's seen as an essential
parameter as much as in linear model regularisation.
|
thomasjpfan
requested changes
Apr 23, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
I am okay with making alpha keyword only in this context.
thomasjpfan
approved these changes
Apr 23, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
* wkonly * pep8
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
* wkonly * pep8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #15005