Skip to content

Release/v0.26.4#2922

Merged
ebuchman merged 20 commits intomasterfrom
release/v0.26.4
Nov 27, 2018
Merged

Release/v0.26.4#2922
ebuchman merged 20 commits intomasterfrom
release/v0.26.4

Conversation

@ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Nov 27, 2018

Changelog

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

ebuchman and others added 20 commits November 17, 2018 18:25
Merge pull request #2873 from tendermint/release/v0.26.3
- rename filterTxs to removeTxs
- move txsMap into removeTxs func
- rename goodTxs to txsLeft
We should add txs that come in from mempool.Update to the mempool's
cache, so that they never hit a potentially expensive check tx.

Originally posted by @ValarDragon in #2846
#2846 (comment)

Refs #2855
Within every tx in the mempool, we store a 64 bit counter,
as an index for when it was inserted into the mempool.
This counter doesn't really serve any purpose.
It was likely added for debugging at one point,
Removing the counter reclaims memory,
which enables greater mempool sizes / mitigates resources at the same size.

Closes #2835
Ref #2827

(I have since seen #2847 which is a fix for the same issue; this PR has tests and docs too ;) )
* update ConsensusState#OnStop comment

* consensus: set logger for WAL in tests

* refactor privValidator client code and tests

follow-up on #2866
* Fixed accepting integer IDs in requests for Tendermint RPC server (#2366)

* added a wrapper interface `jsonrpcid` that represents both string and int IDs in JSON-RPC requests/responses + custom JSON unmarshallers

* changed client-side code in RPC that uses it

* added extra tests for integer IDs

* updated CHANGELOG_PENDING, as suggested by PR instructions

* addressed PR comments

* added table driven tests for request type marshalling/unmarshalling
* expanded handler test to check IDs
* changed pending changelog note

* changed json rpc request/response unmarshalling to use empty interfaces and type switches on ID

* some cleanup
Fixes #2868 where module=main setting overrides all others
…t==0 in replay (#2893)

* optimize addProposalBlockPart

* optimize addProposalBlockPart

* if ProposalBlockParts and LockedBlockParts both exist,let LockedBlockParts overwrite ProposalBlockParts.

* fix tryAddBlock

* broadcast lockedBlockParts in higher priority

* when appHeight==0, it's better fetch genDoc than state.validators.
* fix fastsync may stuck by a wrong block

* fixes from updates

* fixes from review

* Align spec with the changes

* fmt
This commit makes both EventNewBlock and EventNewBlockHeader emit tags
on the event bus, so subscribers can use them in queries.
Modify lookForHeight to return a height only there's a equal operator.
Previously, it was returning a height even for range conditions: "height
< 10000".

Fixes #2759
#2918)

* upadtes in grpc Marshal and unmarshal

* update comments
* prepare changelog

* linkify changelog

* changelog and version

* update changelog
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #2922 into master will increase coverage by 0.6%.
The diff coverage is 61.97%.

@@            Coverage Diff            @@
##           master    #2922     +/-   ##
=========================================
+ Coverage   62.16%   62.76%   +0.6%     
=========================================
  Files         212      212             
  Lines       17292    17410    +118     
=========================================
+ Hits        10749    10928    +179     
+ Misses       5638     5568     -70     
- Partials      905      914      +9
Impacted Files Coverage Δ
state/state.go 90.9% <ø> (ø) ⬆️
consensus/state.go 79.88% <ø> (ø) ⬆️
config/toml.go 53.19% <ø> (ø) ⬆️
rpc/core/events.go 0% <0%> (ø) ⬆️
p2p/node_info.go 75.64% <0%> (-13.76%) ⬇️
tools/tm-bench/transacter.go 8.49% <0%> (ø) ⬆️
evidence/reactor.go 62.62% <0%> (ø) ⬆️
state/execution.go 76.41% <100%> (+0.96%) ⬆️
consensus/replay.go 57.14% <100%> (+0.8%) ⬆️
privval/ipc_server.go 68.51% <100%> (-1.3%) ⬇️
... and 15 more

@ebuchman ebuchman merged commit b771798 into master Nov 27, 2018
@ebuchman ebuchman deleted the release/v0.26.4 branch November 27, 2018 13:51
ebuchman added a commit that referenced this pull request Nov 28, 2018
Merge pull request #2922 from tendermint/release/v0.26.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.