Skip to content

Release/v0.26.3#2873

Merged
ebuchman merged 17 commits intomasterfrom
release/v0.26.3
Nov 17, 2018
Merged

Release/v0.26.3#2873
ebuchman merged 17 commits intomasterfrom
release/v0.26.3

Conversation

@ebuchman
Copy link
Contributor

melekes and others added 17 commits November 15, 2018 14:40
because
- they are locked in .lock file already
- individual dependencies can be updated with `dep ensure -update XXX`
- review process (and ^^^) should help us prevent accidental updates

Closes #2798
* Decouple StartHTTP{,AndTLS}Server from Listen()

This should help solve cosmos/cosmos-sdk#2715

* Fix small mistake

* Update StartGRPCServer

* s/rpc/rpcserver/

* Start grpccore.StartGRPCServer in a goroutine

* Reinstate l.Close()

* Fix rpc/lib/test/main.go

* Update code comment

* update changelog and comments

* fix tm-monitor. more comments
* Introduce a structured logging option

* rename StructuredLog to LogFormat

* add changelog entry

* move log_format under log_level
* wip

* use same ADR template as SDK

* finish docs adr

* lil fixes
…posal event (#2767)

* add proposer info to EventCompleteProposal

* create separate EventData structure for CompleteProposal

* cant us rs.Proposal to get BlockID because it is not guaranteed to be set yet

* copying RoundState isnt helping us here

* add Step back to make compatible with original RoundState event. update changelog

* add NewRound event

* fix test

* remove unneeded RoundState

* put height round step into a struct

* pull out ValidatorInfo struct. add ensureProposal assert

* remove height-round-state sub-struct refactor

* minor fixes from review
Merge pull request #2851 from tendermint/release/v0.26.2
* Vagrantfile: install dev_tools

Follow-up on #2824

* update consensus params spec

* fix test name

* rpc_test: panic if failed to start listener

also
- remove http_server#MustListen
- align StartHTTPServer and StartHTTPAndTLSServer functions

* dep: allow minor releases for grpc
* Make "Update to validators" msg value pretty #2765

* New format for logging validator updates

* Refactor logging validator updates

* Fix changelog item

* fix merge conflict
* p2p/conn: FlushStop. Use in pex. Closes #2092

In seed mode, we call StopPeer immediately after Send.
Since flushing msgs to the peer happens in the background,
the peer connection is often closed before the messages are
actually sent out. The new FlushStop method allows all msgs
to first be written and flushed out on the conn before it is closed.

* fix dummy peer

* typo

* fixes from review

* more comments

* ensure pex doesn't call FlushStop more than once

FlushStop is not safe to call more than once,
but we call it from Receive in a go-routine so Receive
doesn't block.

To ensure we only call it once, we use the lastReceivedRequests
map - if an entry already exists, then FlushStop should already have
been called and we can return.
current code results in panic and we certainly don't want that.
#2286 (comment)
* Replaces our current http servers where connections stay open forever with ones with timeouts to prevent file descriptor exhaustion

* Use the correct handler

* Put in go routines

* fix err

* changelog

* rpc: export Read/WriteTimeout

The `broadcast_tx_commit` endpoint has it's own timeout.
If this is longer than the http server's WriteTimeout, the
user will receive an error. Here, we export the WriteTimeout
and set the broadcast_tx_commit timeout to be less than it.

In the future, we should use a config struct for the timeouts
to avoid the need to export. The broadcast_tx_commit timeout
may also become configurable, but we must check that it's less
than the server's WriteTimeout.
* p2p: NewMultiplexTransport takes an MConnConfig

* changelog

* move test func to test file
…2819)

* #2815 do not broadcast heartbeat proposal when we are non-validator

* #2815 adding preliminary changelog entry

* #2815 cosmetics and added test

* #2815 missed a little detail

- it's enough to call getAddress() once here

* #2815 remove debug logging from tests

* #2815 OK. I seem to be doing something fundamentally wrong here

* #2815 next iteration of proposalHeartbeat tests

- try and use "ensure" pattern in common_test

* 2815 incorporate review comments
* update CONTRIBUTING with notes on CHANGELOG

* update changelog

* changelog and version
@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #2873 into master will decrease coverage by <.01%.
The diff coverage is 59.66%.

@@            Coverage Diff             @@
##           master    #2873      +/-   ##
==========================================
- Coverage   62.17%   62.16%   -0.01%     
==========================================
  Files         212      212              
  Lines       17193    17292      +99     
==========================================
+ Hits        10689    10749      +60     
- Misses       5603     5638      +35     
- Partials      901      905       +4
Impacted Files Coverage Δ
libs/db/fsdb.go 69.78% <ø> (+1.72%) ⬆️
libs/autofile/autofile.go 75% <ø> (-5.83%) ⬇️
rpc/core/pipe.go 30.23% <ø> (ø) ⬆️
config/toml.go 53.19% <ø> (ø) ⬆️
rpc/core/mempool.go 0% <0%> (ø) ⬆️
cmd/tendermint/commands/root.go 51.72% <0%> (-3.84%) ⬇️
lite/proxy/proxy.go 0% <0%> (ø) ⬆️
p2p/peer.go 58.5% <0%> (-1.92%) ⬇️
rpc/grpc/client_server.go 81.81% <100%> (+10.38%) ⬆️
consensus/reactor.go 66.74% <100%> (-0.24%) ⬇️
... and 17 more


## Testing

All repos should be hooked up to [CircleCI](https://circleci.com/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems odd for contributing.md. (It reads to me as your fork should have circle CI testing)

I think it was intended to mean that all of tendermint organization's repos must have commits passing circle CI tests before merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. That's why I moved it to the bottom and will probably break it out all together

Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❄️ 🦃 ☃️

@ebuchman ebuchman merged commit 22dcc92 into master Nov 17, 2018
@ebuchman ebuchman deleted the release/v0.26.3 branch November 17, 2018 23:25
ebuchman added a commit that referenced this pull request Nov 17, 2018
Merge pull request #2873 from tendermint/release/v0.26.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants