Make "Update to validators" msg value pretty #2848
Merged
ebuchman merged 6 commits intotendermint:developfrom Nov 16, 2018
Merged
Make "Update to validators" msg value pretty #2848ebuchman merged 6 commits intotendermint:developfrom
ebuchman merged 6 commits intotendermint:developfrom
Conversation
ValarDragon
reviewed
Nov 15, 2018
ebuchman
approved these changes
Nov 15, 2018
ebuchman
reviewed
Nov 15, 2018
|
|
||
| // updateState returns a new State updated according to the header and responses. | ||
| func updateState( | ||
| logger log.Logger, |
Contributor
There was a problem hiding this comment.
Oh - we were probably logging it where we were before to avoid having to pass the logger here.
Not sure what exactly would be better here - but we do want to do a better job of separating our logging from our logic.
Maybe the abci responses should be processed into a new form (ie. call all the PB2TM) before calling this? Then the logging can happen before calling this as well and we wouldn't need to pass the logger in.
Thoughts?
Contributor
Author
There was a problem hiding this comment.
I agree. Think that such kind of refactoring deserves separate issue/PR.
Codecov Report
@@ Coverage Diff @@
## develop #2848 +/- ##
===========================================
+ Coverage 62.16% 62.18% +0.01%
===========================================
Files 212 212
Lines 17227 17230 +3
===========================================
+ Hits 10710 10714 +4
Misses 5614 5614
+ Partials 903 902 -1
|
ebuchman
approved these changes
Nov 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2765
Updated all relevant documentation in docsUpdated all code comments where relevantWrote tests