It's better read from genDoc than from state.validators when appHeight==0 in replay#2893
Merged
ebuchman merged 9 commits intotendermint:developfrom Nov 26, 2018
Merged
It's better read from genDoc than from state.validators when appHeight==0 in replay#2893ebuchman merged 9 commits intotendermint:developfrom
ebuchman merged 9 commits intotendermint:developfrom
Conversation
…Parts overwrite ProposalBlockParts.
# Conflicts: # consensus/state.go
Codecov Report
@@ Coverage Diff @@
## develop #2893 +/- ##
==========================================
Coverage ? 62.18%
==========================================
Files ? 212
Lines ? 17309
Branches ? 0
==========================================
Hits ? 10764
Misses ? 5637
Partials ? 908
|
ebuchman
approved these changes
Nov 26, 2018
Contributor
ebuchman
left a comment
There was a problem hiding this comment.
Thanks for catching this!
danil-lashin
pushed a commit
to danil-lashin/tendermint
that referenced
this pull request
Nov 27, 2018
* develop: types: Emit tags from BeginBlock/EndBlock (tendermint#2747) Fix fast sync stack with wrong block tendermint#2457 (tendermint#2731) It's better read from genDoc than from state.validators when appHeight==0 in replay (tendermint#2893) update encoding spec (tendermint#2903) return back initially allowed level if we encounter allowed key (tendermint#2889) Handling integer IDs in JSON-RPC requests -- fixes tendermint#2366 (tendermint#2811) # Conflicts: # blockchain/reactor_test.go # blockchain/store_test.go # node/node_test.go # types/events.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2892