node: refactor privValidator ext client code & tests#2895
Merged
Conversation
be32465 to
222a6d3
Compare
follow-up on #2866
222a6d3 to
bb1c46c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2895 +/- ##
==========================================
Coverage ? 62.25%
==========================================
Files ? 212
Lines ? 17260
Branches ? 0
==========================================
Hits ? 10745
Misses ? 5613
Partials ? 902
|
liamsi
reviewed
Nov 21, 2018
| "github.com/rs/cors" | ||
|
|
||
| "github.com/tendermint/go-amino" | ||
| amino "github.com/tendermint/go-amino" |
Contributor
There was a problem hiding this comment.
I never understood why we alias here.
Contributor
Author
There was a problem hiding this comment.
go-imports bin does this automatically. in short: because amino != go-amino
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up on #2866