Skip to content

Remove counter from every mempoolTx#2891

Merged
melekes merged 1 commit intodevelopfrom
dev/mempool_counter
Nov 21, 2018
Merged

Remove counter from every mempoolTx#2891
melekes merged 1 commit intodevelopfrom
dev/mempool_counter

Conversation

@ValarDragon
Copy link
Contributor

Within every tx in the mempool, we store a 64 bit counter,
as an index for when it was inserted into the mempool.
This counter doesn't really serve any purpose.
It was likely added for debugging at one point,
Removing the counter reclaims memory,
which enables greater mempool sizes / mitigates resources at the same size.

Closes #2835

  • Updated all relevant documentation in docs - not mentioned in docs
  • Wrote tests - current tests all pass
  • Updated CHANGELOG_PENDING.md

Within every tx in the mempool, we store a 64 bit counter,
as an index for when it was inserted into the mempool.
This counter doesn't really serve any purpose.
It was likely added for debugging at one point,
Removing the counter reclaims memory,
which enables greater mempool sizes / mitigates resources at the same size.

Closes #2835
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍨

@melekes melekes merged commit 1610a05 into develop Nov 21, 2018
@melekes melekes deleted the dev/mempool_counter branch November 21, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants