#2877 include BlockTimeIota should be included in default config toml#2878
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2878 +/- ##
===========================================
+ Coverage 62.1% 62.15% +0.04%
===========================================
Files 212 212
Lines 17288 17292 +4
===========================================
+ Hits 10736 10747 +11
+ Misses 5647 5639 -8
- Partials 905 906 +1
|
|
@milosevic is there a reason |
de00283 to
38dd02b
Compare
|
There is no reason why it hasn't been included; we most probably forgot to do it. |
| peer_query_maj23_sleep_duration = "{{ .Consensus.PeerQueryMaj23SleepDuration }}" | ||
|
|
||
| # Block time parameters. Corresponds to the minimum time increment between consecutive blocks. | ||
| blocktime_iota = "{{ .Consensus.BlockTimeIota }}" |
There was a problem hiding this comment.
we should probably change this to block_time_iota. Also the description doesn't help distinguish it from TimeoutCommit - should be clear that this refers to the timestamp.
Also, isn't it a ConsensusParam, rather than just a config option, @milosevic ?
There was a problem hiding this comment.
I agree that description should clearly say this is only about timestamp. Yep it's a ConsensusParam (definition: ConsensusParams contains consensus critical parameters that determine the validity of blocks.).
Uh oh!
There was an error while loading. Please reload this page.