Skip to content

kv indexer: order results by index if height is the same#2900

Merged
ebuchman merged 2 commits intodevelopfrom
2775-order-txs-by-index
Nov 27, 2018
Merged

kv indexer: order results by index if height is the same#2900
ebuchman merged 2 commits intodevelopfrom
2775-order-txs-by-index

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Nov 23, 2018

Before we're only sorting by height.

Fixes #2775

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@melekes melekes requested a review from ebuchman as a code owner November 23, 2018 09:06
@codecov-io
Copy link

Codecov Report

Merging #2900 into develop will decrease coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2900      +/-   ##
===========================================
- Coverage     62.4%   62.32%   -0.08%     
===========================================
  Files          212      212              
  Lines        17254    17248       -6     
===========================================
- Hits         10767    10750      -17     
- Misses        5583     5593      +10     
- Partials       904      905       +1
Impacted Files Coverage Δ
state/txindex/kv/kv.go 75.32% <100%> (+0.1%) ⬆️
libs/db/debug_db.go 16% <0%> (-4.64%) ⬇️
lite/base_verifier.go 76% <0%> (-2.95%) ⬇️
privval/tcp_server.go 78.57% <0%> (-2.86%) ⬇️
p2p/pex/pex_reactor.go 71.51% <0%> (-0.95%) ⬇️
p2p/pex/addrbook.go 68.91% <0%> (-0.49%) ⬇️
privval/tcp.go 71.08% <0%> (-0.19%) ⬇️
libs/db/remotedb/grpcdb/server.go 0% <0%> (ø) ⬆️
blockchain/pool.go 66.43% <0%> (+0.69%) ⬆️

@melekes melekes self-assigned this Nov 27, 2018
@ebuchman ebuchman merged commit 94e63be into develop Nov 27, 2018
@ebuchman ebuchman deleted the 2775-order-txs-by-index branch November 27, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants