Skip to content

Try to make coderabbit respect exisiting type labels#8042

Merged
stefanv merged 2 commits intoscikit-image:mainfrom
lagru:coderabbit-respect-labels
Feb 1, 2026
Merged

Try to make coderabbit respect exisiting type labels#8042
stefanv merged 2 commits intoscikit-image:mainfrom
lagru:coderabbit-respect-labels

Conversation

@lagru
Copy link
Copy Markdown
Member

@lagru lagru commented Jan 29, 2026

Description

I was very tempted to just remove the auto-labeling altogether. Attempting a fix since I think @stefanv cares about it labeling new PRs from outside contributors.

Checklist

Release note

For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.

...

@lagru lagru requested a review from stefanv January 29, 2026 10:24
@lagru lagru added the 🤖 type: Infrastructure CI, packaging, tools and automation label Jan 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 29, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updated .coderabbit.yaml labeling_instructions: replaced "Mutually exclusive." guidance with a global conditional "Only apply if no 'type:' label is already assigned." Added domain-scoped exclusions to several labels and clarified applicability for bug fixes.

Changes

Cohort / File(s) Summary
Labeling Configuration
.coderabbit.yaml		 Replaced per-label "Mutually exclusive." text with a global conditional: "Only apply if no 'type:' label is already assigned." Removed mutual-exclusivity wording for New feature, Bug fix, Maintenance, API, Documentation, Infrastructure, Enhancement (Efficiency-related), and Performance labels. Added domain-scoped exclusions for New feature, Bug fix, and Enhancement (tooling, infrastructure, similar areas). Clarified Bug fix should target user-facing API changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: making coderabbit respect existing type labels to prevent auto-labeling conflicts.
Description check ✅ Passed The description explains the rationale for the change and mentions the fix is to respect existing type labels, which aligns with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

stefanv
stefanv reviewed Jan 29, 2026
View reviewed changes
.coderabbit.yaml
instructions: >-
Improvements made to an existing feature. Mutually exclusive.
Improvements made to an existing feature.
Improvements for tooling, infrastructure and such shouldn't use this label.
Copy link
Copy Markdown
Member

@stefanv stefanv Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would phrase this along the lines of:

"Mutually exclusive with labels a, b, c." or "Do not apply this label in combination with a, b, c."

Copy link
Copy Markdown
Member Author

@lagru lagru Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is not exactly about the "mutually exclusive" part, but about which exclusive label to chose when multiple apply.

@stefanv
Copy link
Copy Markdown
Member

stefanv commented Jan 29, 2026

The PR removes the general mutual exclusivity of type labels: is this what is desired?

@lagru
Copy link
Copy Markdown
Member Author

lagru commented Jan 29, 2026

The PR removes the general mutual exclusivity of type labels: is this what is desired?

I'm not following? I think I reworded the "mutual exclusivity" because coderabbit didn't seem to "get it".

@lagru lagru requested a review from stefanv January 30, 2026 17:03
lagru and others added 2 commits January 31, 2026 16:43
@stefanv stefanv force-pushed the coderabbit-respect-labels branch from 18b1f40 to 595b150 Compare February 1, 2026 00:43
@stefanv stefanv merged commit b118e59 into scikit-image:main Feb 1, 2026
22 of 25 checks passed
@stefanv stefanv added this to the 0.27 milestone Feb 1, 2026
@coderabbitai coderabbitai bot mentioned this pull request Feb 27, 2026
Merged
@lagru lagru deleted the coderabbit-respect-labels branch March 4, 2026 15:02
matthew-brett added a commit that referenced this pull request Apr 10, 2026
@matthew-brett
Merge remote-tracking branch 'origin/main' into refactor-test-pp-hough
367020a 
* origin/main: (27 commits)
  Move `_shared` to `_skimage2` (#8102)
  Port `pad_footprint` & `mirror_footprint` to `skimage2` (#8094)
  Add rescaling API to skimage2 (#8075)
  Move `skimage2` implementation into `_skimage2` (#8093)
  Undo (double) mirroring in `ski2.morphology.dilation` (#8060)
  Grammar (#8091)
  Move `ensure_spacing` into `skimage2` (#8067)
  Ensure that `skimage2` does not eagerly import `skimage` (#8087)
  Use lazy-loader 0.5 (#8080)
  MAINT: make ellipse fitting forward compatible  (#8054)
  Avoid deprecated assign to ndarray.shape (#8020)
  Avoid circular import in `feature/corner.py` (#8077)
  Turn off coderabbit auto-labeling & label checks (#8070)
  Fix GIL being re-enabled by C++ extensions (#8059)
  Fix conventions following docstub and misc. (#8055)
  Port grayscale morphology operators to skimage2 (#8046)
  Add revised `peak_local_max` to `skimage2` (#8039)
  Allow read-only arrays as input to remap (#7535)
  Add `prescale`  parameter to "blob functions" (#7858)
  Try to make coderabbit respect exisiting type labels (#8042)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanv stefanv stefanv approved these changes

Assignees

No one assigned

Labels

🤖 type: Infrastructure CI, packaging, tools and automation

Projects

None yet

Milestone

0.27

Development

Successfully merging this pull request may close these issues.

2 participants

@lagru @stefanv