Skip to content

Avoid circular import in feature/corner.py#8077

Merged
lagru merged 2 commits intoscikit-image:mainfrom
stefanv:fix-CI
Mar 4, 2026
Merged

Avoid circular import in feature/corner.py#8077
lagru merged 2 commits intoscikit-image:mainfrom
stefanv:fix-CI

Conversation

@stefanv
Copy link
Copy Markdown
Member

@stefanv stefanv commented Mar 4, 2026

No description provided.

@coderabbitai coderabbitai bot added the 🔧 type: Maintenance Refactoring and maintenance of internals label Mar 4, 2026
@coderabbitai

This comment was marked as outdated.

@lagru lagru changed the title Avoid circular import Avoid circular import in feature/corner.py Mar 4, 2026
@lagru
Copy link
Copy Markdown
Member

lagru commented Mar 4, 2026

Waiting for the CI to see if it being green is a fluke – merging if it's green.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c2640e8d-90b2-4ce0-95d4-4925f9a4d53b

📥 Commits

Reviewing files that changed from the base of the PR and between 390b2a8 and 844f9c1.

📒 Files selected for processing (1)
  • src/skimage/feature/corner.py

@lagru lagru merged commit 856343a into scikit-image:main Mar 4, 2026
26 checks passed
@stefanv stefanv added this to the 0.27 milestone Mar 4, 2026
lagru added a commit to lagru/scikit-image that referenced this pull request Mar 4, 2026
Co-authored-by: Lars Grüter <lagru@mailbox.org>
matthew-brett added a commit that referenced this pull request Apr 10, 2026
* origin/main: (27 commits)
  Move `_shared` to `_skimage2` (#8102)
  Port `pad_footprint` & `mirror_footprint` to `skimage2` (#8094)
  Add rescaling API to skimage2 (#8075)
  Move `skimage2` implementation into `_skimage2` (#8093)
  Undo (double) mirroring in `ski2.morphology.dilation` (#8060)
  Grammar (#8091)
  Move `ensure_spacing` into `skimage2` (#8067)
  Ensure that `skimage2` does not eagerly import `skimage` (#8087)
  Use lazy-loader 0.5 (#8080)
  MAINT: make ellipse fitting forward compatible  (#8054)
  Avoid deprecated assign to ndarray.shape (#8020)
  Avoid circular import in `feature/corner.py` (#8077)
  Turn off coderabbit auto-labeling & label checks (#8070)
  Fix GIL being re-enabled by C++ extensions (#8059)
  Fix conventions following docstub and misc. (#8055)
  Port grayscale morphology operators to skimage2 (#8046)
  Add revised `peak_local_max` to `skimage2` (#8039)
  Allow read-only arrays as input to remap (#7535)
  Add `prescale`  parameter to "blob functions" (#7858)
  Try to make coderabbit respect exisiting type labels (#8042)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔧 type: Maintenance Refactoring and maintenance of internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants