Skip to content

Use lazy-loader 0.5#8080

Merged
jni merged 1 commit intoscikit-image:mainfrom
stefanv:lazy-loader-0.5
Mar 9, 2026
Merged

Use lazy-loader 0.5#8080
jni merged 1 commit intoscikit-image:mainfrom
stefanv:lazy-loader-0.5

Conversation

@stefanv
Copy link
Copy Markdown
Member

@stefanv stefanv commented Mar 8, 2026

This version no longer interprets EAGER_IMPORT=0 as equivalent to EAGER_IMPORT=true.

@stefanv stefanv added the 🔧 type: Maintenance Refactoring and maintenance of internals label Mar 8, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 8, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e9e0f8b9-b08b-4742-9c06-f2f9adfcf271

📥 Commits

Reviewing files that changed from the base of the PR and between 353c852 and ea46012.

📒 Files selected for processing (3)
  • environment.yml
  • pyproject.toml
  • requirements/default.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
📝 Walkthrough

Walkthrough

Updated the lazy-loader dependency constraint from >=0.4 to >=0.5 in project dependency declarations. No functional changes or exported/public entity modifications.

Changes

Cohort / File(s) Summary
Dependency Version Updates
environment.yml, pyproject.toml, requirements/default.txt		 Bumped lazy-loader minimum version constraint from >=0.4 to >=0.5 in dependency and build-system declarations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Use lazy-loader 0.5' is concise, descriptive, directly relates to the main change (updating lazy-loader dependency to version 0.5), and is under 80 characters.
Description check ✅ Passed The description clearly relates to the changeset by explaining a key behavioral change in lazy-loader 0.5 regarding EAGER_IMPORT environment variable interpretation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Mar 8, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
pyproject.toml (1)

28-38: ⚠️ Potential issue | 🟠 Major

Bump the build-time floor to lazy_loader>=0.5 too.

Line 130 in [build-system].requires still permits lazy_loader 0.4 in isolated builds, creating an inconsistency with the runtime minimum. This prevents the PR from fully enforcing the lazy-loader 0.5 minimum across build-time environments. Update [build-system].requires to match the runtime floor.

Suggested fix 
 [build-system]
 requires = [
     'meson-python>=0.16',
     'Cython>=3.0.10,!=3.2.0b1',
     'pythran>=0.16',
-    'lazy_loader>=0.4',
+    'lazy_loader>=0.5',
     'numpy>=2.0',
 ]
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 78d492f7-a3a3-4ad9-bf69-866394b07c82

📥 Commits

Reviewing files that changed from the base of the PR and between b9b377c and 353c852.

📒 Files selected for processing (3)
  • environment.yml
  • pyproject.toml
  • requirements/default.txt

@stefanv
Use lazy-loader 0.5
ea46012 
This version no longer interprets EAGER_IMPORT=0 as equivalent to
EAGER_IMPORT=true.
@jni jni merged commit 862aaf6 into scikit-image:main Mar 9, 2026
25 checks passed
@jni jni deleted the lazy-loader-0.5 branch March 9, 2026 00:40
@stefanv stefanv added this to the 0.27 milestone Mar 9, 2026
@lagru lagru added 🩹 type: Bug fix Fixes unexpected or incorrect behavior 🔧 type: Maintenance Refactoring and maintenance of internals and removed 🔧 type: Maintenance Refactoring and maintenance of internals 🩹 type: Bug fix Fixes unexpected or incorrect behavior labels Mar 9, 2026
matthew-brett added a commit that referenced this pull request Apr 10, 2026
@matthew-brett
Merge remote-tracking branch 'origin/main' into refactor-test-pp-hough
367020a 
* origin/main: (27 commits)
  Move `_shared` to `_skimage2` (#8102)
  Port `pad_footprint` & `mirror_footprint` to `skimage2` (#8094)
  Add rescaling API to skimage2 (#8075)
  Move `skimage2` implementation into `_skimage2` (#8093)
  Undo (double) mirroring in `ski2.morphology.dilation` (#8060)
  Grammar (#8091)
  Move `ensure_spacing` into `skimage2` (#8067)
  Ensure that `skimage2` does not eagerly import `skimage` (#8087)
  Use lazy-loader 0.5 (#8080)
  MAINT: make ellipse fitting forward compatible  (#8054)
  Avoid deprecated assign to ndarray.shape (#8020)
  Avoid circular import in `feature/corner.py` (#8077)
  Turn off coderabbit auto-labeling & label checks (#8070)
  Fix GIL being re-enabled by C++ extensions (#8059)
  Fix conventions following docstub and misc. (#8055)
  Port grayscale morphology operators to skimage2 (#8046)
  Add revised `peak_local_max` to `skimage2` (#8039)
  Allow read-only arrays as input to remap (#7535)
  Add `prescale`  parameter to "blob functions" (#7858)
  Try to make coderabbit respect exisiting type labels (#8042)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@jni jni jni approved these changes

Assignees

No one assigned

Labels

🔧 type: Maintenance Refactoring and maintenance of internals

Projects

None yet

Milestone

0.27

Development

Successfully merging this pull request may close these issues.

3 participants

@stefanv @jni @lagru