src/skimage/morphology/footprints.py (1)

9-9: Use relative import instead of absolute import.

This line uses an absolute import, but the coding guidelines specify using relative module imports within src/skimage/**/*.py.

♻️ Proposed fix

-from skimage import morphology
+from . import _top_level_morphology as morphology

Alternatively, if the import is only used in footprint_from_sequence at line 100, consider importing directly where needed or restructuring to avoid the circular dependency that may have motivated this pattern.

As per coding guidelines: "Use relative module imports (e.g., from .._shared import xyz instead of from skimage._shared import xyz)".

tests/skimage2/morphology/test_grayscale_operators.py (1)

52-66: Consider extracting the test data loading to a fixture.

The NPZ file is loaded on every parameterized test execution (36 times for this test alone). Using a module-scoped fixture would reduce redundant I/O.

Additionally, there's a minor inconsistency: np.testing.assert_equal is used here while assert_array_equal (which is already imported) is used elsewhere in the file.

♻️ Proposed fixture to cache test data

`@pytest.fixture`(scope="module")
def gray_morph_expected_data():
    return dict(np.load(fetch('data/gray_morph_output.npz')))

Then use gray_morph_expected_data in both test methods:

-    def test_reproduce_skimage_data_not_mirrored(self, footprint_args, size, func):
+    def test_reproduce_skimage_data_not_mirrored(self, footprint_args, size, func, gray_morph_expected_data):
         ...
         footprint_name, footprint_func = footprint_args
         key = f'{footprint_name}_{size}_{func.__name__}'
-        data = dict(np.load(fetch('data/gray_morph_output.npz')))
-        expected = data[key]
+        expected = gray_morph_expected_data[key]
         footprint = footprint_func(size)

         result = func(image, footprint, mode="reflect")
-        np.testing.assert_equal(result, expected)
+        assert_array_equal(result, expected)

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

doc/source/user_guide/skimage2_migration.md (1)

134-134: ⚠️ Potential issue | 🟡 Minor

Fix grammar in the migration note sentence.

Line 134 should read “This only impacts behavior...” (current text has incorrect grammar: “does only impacts”).

✏️ Proposed fix

-  This does only impacts behavior for asymmetric/eccentric footprints.
+  This only impacts behavior for asymmetric/eccentric footprints.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

src/skimage/morphology/gray.py (1)

46-54: Make the warning snippet self-contained.

This message tells users to call ski2.morphology.*, but ski2 is never introduced in the warning itself. Using fully qualified skimage2.morphology.pad_footprint / skimage2.morphology.mirror_footprint, or adding the import line, would make the migration hint copy-pasteable as-is.