tests/skimage2/morphology/test_grayscale_operators.py (1)

14-26: Redundant imports inside fixtures.

The from skimage import data statements on lines 16 and 23 are unnecessary since data is already imported at module level (line 6).

♻️ Suggested cleanup

 `@pytest.fixture`
 def cam_image():
-    from skimage import data
-
     return np.ascontiguousarray(data.camera()[64:112, 64:96])


 `@pytest.fixture`
 def cell3d_image():
-    from skimage import data
-
     return np.ascontiguousarray(data.cells3d()[30:48, 0, 20:36, 20:32])

src/skimage2/morphology/_grayscale_operators.py (1)

626-628: Inconsistent dtype check for boolean.

Line 627 uses np.bool_ while similar checks elsewhere (lines 529, 537, 620) use bool. Both work, but consistency improves readability.

♻️ Proposed fix for consistency

     out = closing(image, footprint, out=out, mode=mode, cval=cval)
-    if np.issubdtype(out.dtype, np.bool_):
+    if np.issubdtype(out.dtype, bool):
         np.logical_xor(out, image, out=out)

src/skimage2/morphology/_grayscale_operators.py (3)

5-7: Use project SciPy import convention (import scipy as sp).
The module currently uses from scipy import ndimage as ndi, which diverges from the project import convention. Switching to import scipy as sp keeps imports consistent and avoids extra aliases.

♻️ Proposed refactor

-from scipy import ndimage as ndi
+import scipy as sp
@@
-        operator=ndi.grey_erosion,
+        operator=sp.ndimage.grey_erosion,
@@
-        operator=ndi.grey_dilation,
+        operator=sp.ndimage.grey_dilation,

As per coding guidelines: Use the import convention: import numpy as np, import matplotlib.pyplot as plt, import scipy as sp, import skimage as ski.

Also applies to: 193-201, 296-303

---

8-13: Prefer relative imports for morphology helpers in skimage2.
These imports couple skimage2 directly to the v1 namespace. If the helpers are (or will be) available under skimage2.morphology, consider switching to relative imports to keep dependency direction clean.

♻️ Example (if skimage2 equivalents exist)

-from skimage.morphology.footprints import (
+from .footprints import (
     _footprint_is_sequence,
     mirror_footprint,
     pad_footprint,
 )
-from skimage.morphology.misc import default_footprint
+from .misc import default_footprint

As per coding guidelines: Use relative module imports (e.g., from .._shared import xyz rather than from skimage._shared import xyz).

---

113-118: Document array shapes in parameter sections (M, N) format.
The public API docstrings use image : ndarray; the guidelines require shape-aware forms like image : (M, N) ndarray and references to rows/columns. Please update across these functions.

📝 Example update (apply similarly to other functions)

-    image : ndarray
-        Input image.
+    image : (M, N) ndarray
+        Input image with M rows and N columns.

As per coding guidelines: When documenting array parameters, use the format 'image : (M, N) ndarray' and refer to M and N in the docstring.

Also applies to: 213-218, 316-321, 390-395, 463-468, 553-558