Merged
Conversation
Co-authored-by: Michael Bratsch <michael.bratsch83@gmail.com>
Conflicts: src/skimage/filters/rank/generic.py src/skimage/morphology/binary.py src/skimage/morphology/footprints.py
blink1073
approved these changes
Mar 31, 2026
Contributor
blink1073
left a comment
There was a problem hiding this comment.
I reviewed all 274(!) files. Looks good to me!
stefanv
approved these changes
Apr 7, 2026
Member
|
Thanks for reviewing, @blink1073! |
matthew-brett
added a commit
to matthew-brett/scikit-image
that referenced
this pull request
Apr 9, 2026
* origin/main: Move `_shared` to `_skimage2` (scikit-image#8102)
matthew-brett
added a commit
that referenced
this pull request
Apr 10, 2026
* origin/main: (27 commits) Move `_shared` to `_skimage2` (#8102) Port `pad_footprint` & `mirror_footprint` to `skimage2` (#8094) Add rescaling API to skimage2 (#8075) Move `skimage2` implementation into `_skimage2` (#8093) Undo (double) mirroring in `ski2.morphology.dilation` (#8060) Grammar (#8091) Move `ensure_spacing` into `skimage2` (#8067) Ensure that `skimage2` does not eagerly import `skimage` (#8087) Use lazy-loader 0.5 (#8080) MAINT: make ellipse fitting forward compatible (#8054) Avoid deprecated assign to ndarray.shape (#8020) Avoid circular import in `feature/corner.py` (#8077) Turn off coderabbit auto-labeling & label checks (#8070) Fix GIL being re-enabled by C++ extensions (#8059) Fix conventions following docstub and misc. (#8055) Port grayscale morphology operators to skimage2 (#8046) Add revised `peak_local_max` to `skimage2` (#8039) Allow read-only arrays as input to remap (#7535) Add `prescale` parameter to "blob functions" (#7858) Try to make coderabbit respect exisiting type labels (#8042) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves our
_sharedsubmodule to the_skimage2namespace. That's useful going forward because it better matches our desired import hierarchy. We don't need to worry about API cleanup, documentation and migration advice because all this stuff is internal.I tried to keep this PR as small as possible. Further cleanup of the
_sharedmodule should probably happen in followup PRs.Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.