Skip to content

Move skimage2 implementation into _skimage2#8093

Merged
lagru merged 4 commits intoscikit-image:mainfrom
lagru:sk2-split-skimage2
Mar 17, 2026
Merged

Move skimage2 implementation into _skimage2#8093
lagru merged 4 commits intoscikit-image:mainfrom
lagru:sk2-split-skimage2

Conversation

@lagru
Copy link
Copy Markdown
Member

@lagru lagru commented Mar 14, 2026

Description

This gives us an option to import the skimage2 API for wrappers in skimage without triggering the ExperimentalAPIWarning.

Checklist

Release note

For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.

...

This gives us an option to import the skimage2 API for wrappers in
skimage without triggering the ExperimentalAPIWarning.
@lagru lagru added 🔧 type: Maintenance Refactoring and maintenance of internals 🥾 Path to skimage2 A step towards the new "API 2.0" labels Mar 14, 2026
@github-project-automation github-project-automation bot moved this to Pitched in Work pitches Mar 14, 2026
@lagru lagru moved this from Pitched to Doing in Work pitches Mar 14, 2026
@lagru lagru self-assigned this Mar 14, 2026
@greptile-apps

This comment was marked as outdated.

@lagru lagru moved this from Doing to Review in Work pitches Mar 14, 2026
Copy link
Copy Markdown
Member

@stefanv stefanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with you merging optimistically, and just continuing making changes until everything works.

Comment on lines +8 to +10
# Will simulate the namespace of `_skimage2` as close as possible.
# This does not seem to work for `help(skimage2)` though and won't fool
# inspection tools, that look for actual subdirectories.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanv, in #8093 (review) you say

I'm fine with you merging optimistically, and just continuing making changes until everything works.

What are you referring to? This comment?

@lagru lagru merged commit 327b112 into scikit-image:main Mar 17, 2026
24 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Work pitches Mar 17, 2026
@lagru lagru deleted the sk2-split-skimage2 branch March 17, 2026 15:40
@stefanv stefanv added this to the 0.27 milestone Mar 17, 2026
matthew-brett added a commit that referenced this pull request Apr 10, 2026
* origin/main: (27 commits)
  Move `_shared` to `_skimage2` (#8102)
  Port `pad_footprint` & `mirror_footprint` to `skimage2` (#8094)
  Add rescaling API to skimage2 (#8075)
  Move `skimage2` implementation into `_skimage2` (#8093)
  Undo (double) mirroring in `ski2.morphology.dilation` (#8060)
  Grammar (#8091)
  Move `ensure_spacing` into `skimage2` (#8067)
  Ensure that `skimage2` does not eagerly import `skimage` (#8087)
  Use lazy-loader 0.5 (#8080)
  MAINT: make ellipse fitting forward compatible  (#8054)
  Avoid deprecated assign to ndarray.shape (#8020)
  Avoid circular import in `feature/corner.py` (#8077)
  Turn off coderabbit auto-labeling & label checks (#8070)
  Fix GIL being re-enabled by C++ extensions (#8059)
  Fix conventions following docstub and misc. (#8055)
  Port grayscale morphology operators to skimage2 (#8046)
  Add revised `peak_local_max` to `skimage2` (#8039)
  Allow read-only arrays as input to remap (#7535)
  Add `prescale`  parameter to "blob functions" (#7858)
  Try to make coderabbit respect exisiting type labels (#8042)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🥾 Path to skimage2 A step towards the new "API 2.0" 🔧 type: Maintenance Refactoring and maintenance of internals

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants