Create package rosidl_core_generators#22
Merged
jacobperron merged 4 commits intorollingfrom Aug 23, 2022
Merged
Conversation
Move contents of rosidl_default_generators into the new package. This package is contains dependencies for code generation of ROS messages. rosidl_default_generators now depends on the new package, plus message definitions required for Actions (namely action_msgs). This allows users to avoid having to explictly depend on action_msgs. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/rcl_interfaces
that referenced
this pull request
Aug 2, 2022
This allows us to forward a dependency on action_msgs for users and avoid a dependency cycle. Connected to ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
Though this avoids a dependency cycle with action_msgs, I just realized this creates a cycle at the repository level. So, if this is an approved solution we should consider moving the new package to it's own repository. |
Member
Author
|
Note, I think we also require ros2/rosidl#696 in order to avoid the dependency cycle. |
This was referenced Aug 2, 2022
jacobperron
commented
Aug 9, 2022
This was referenced Aug 9, 2022
ivanpauno
reviewed
Aug 16, 2022
ivanpauno
requested changes
Aug 16, 2022
Member
ivanpauno
left a comment
There was a problem hiding this comment.
About the name of the new package, I don't have suggestions, but the distinction between "code" and "defaults" is confusing.
LGTM when the new package is moved to another repo (if not, it will create a circular dependency when bloom-releasing).
jacobperron
added a commit
to ros2/rosidl_core
that referenced
this pull request
Aug 18, 2022
Moved (and renamed) from rosidl_defaults. Related PR: ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
https://github.com/ros2/rosidl_core.git Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Move rosidl_default_runtime to rosidl_core_runtime, depend on rosidl_core_runtime, and depend on action_msgs. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/ros2
that referenced
this pull request
Aug 18, 2022
Connected to ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/unique_identifier_msgs
that referenced
this pull request
Aug 18, 2022
This allows us to forward a dependency on action_msgs for users and avoid a dependency cycle. Connected to ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
@ivanpauno I've updated this PR, moving the new "core" packages their own repositories. I've updated this PRs description with an updated list of connected PRs. |
ivanpauno
reviewed
Aug 18, 2022
Member
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM when the only open discussion is resolved (and CI is green)
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
Full CI with all connected PRs:
|
ihasdapie
approved these changes
Aug 18, 2022
ivanpauno
approved these changes
Aug 23, 2022
jacobperron
added a commit
to ros2/rosidl_core
that referenced
this pull request
Aug 23, 2022
* Add generators and runtime configuration packages Moved (and renamed) from rosidl_defaults. Related PR: ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add README files and update the rosidl_core_runtime README Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/ros2
that referenced
this pull request
Aug 23, 2022
Connected to ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/rcl_interfaces
that referenced
this pull request
Aug 23, 2022
* Depend on rosidl_core_generators for packages required by actions This allows us to forward a dependency on action_msgs for users and avoid a dependency cycle. Connected to ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove action_msgs dependency from test_msgs It is now properly included in the rosidl dependency chain. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Depend on rosidl_core_runtime for packages depended on by actions Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update quality declarations Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/unique_identifier_msgs
that referenced
this pull request
Aug 23, 2022
This allows us to forward a dependency on action_msgs for users and avoid a dependency cycle. Connected to ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
hoffmann-stefan
added a commit
to hoffmann-stefan/ros2_dotnet
that referenced
this pull request
May 18, 2023
In ros2/rosidl_defaults#22, the rosidl_core_generators package was split off from rosidl_defaults into a separate repo, which needed to be added. Without this repository the dotnet code for the interfaces is not generated in the workspace. see PR on ros2-rust: ros2-rust/ros2_rust#251
Jiusi-pys
pushed a commit
to Jiusi-pys/ros2
that referenced
this pull request
Jan 17, 2026
Connected to ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move contents of rosidl_default_generators into the new package.
This package contains dependencies for code generation of ROS messages.
rosidl_default_generators now depends on the new package, plus message definitions required for Actions (namely action_msgs).
This allows users to avoid having to explictly depend on action_msgs.
Connected to
Downstream PRs removing the dependency:
Documentation PRs: