Conversation
Contributor
Author
|
It appears |
jhdcs
approved these changes
Aug 31, 2022
hoffmann-stefan
added a commit
to hoffmann-stefan/ros2_dotnet
that referenced
this pull request
May 18, 2023
In ros2/rosidl_defaults#22, the rosidl_core_generators package was split off from rosidl_defaults into a separate repo, which needed to be added. Without this repository the dotnet code for the interfaces is not generated in the workspace. see PR on ros2-rust: ros2-rust/ros2_rust#251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build was broken, with an error about a missing
rosidl_core_generatorspackage that is a dependency of message packages.In ros2/rosidl_defaults#22, this package was split off from
rosidl_defaultsinto a separate repo, which needed to be added.I also changed the branches from 'master' to 'rolling', since they were renamed in all ROS 2 repos.