Move rosidl_cmake Python module to a new package rosidl_pycommon#696
Merged
jacobperron merged 3 commits intorollingfrom Aug 10, 2022
Merged
Move rosidl_cmake Python module to a new package rosidl_pycommon#696jacobperron merged 3 commits intorollingfrom
jacobperron merged 3 commits intorollingfrom
Conversation
Deprecate the Python module in rosidl_cmake and move the implementation to the new package rosidl_pycommon. This works towards removing a dependency on rosidl_cmake in generator packages. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This was referenced Aug 2, 2022
hidmic
approved these changes
Aug 9, 2022
Contributor
hidmic
left a comment
There was a problem hiding this comment.
This makes total sense to me, pending green CI.
We could also have tests for rosidl_pycommon now :)
Member
Author
+1, I was actually thinking about doing that. Maybe in a follow-up PR to keep the changes logically separate. |
Member
Author
|
CI for this PR and the following connected PRs:
|
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This decouples the common Python module from the package providing the cmake entrypoint.
Part of an effort to de-tangle the rosidl dependency graph and remove a dependency loop wrt to
action_msgs.