Depend on rosidl_core_generators for packages required by actions#144
Merged
jacobperron merged 4 commits intorollingfrom Aug 23, 2022
Merged
Depend on rosidl_core_generators for packages required by actions#144jacobperron merged 4 commits intorollingfrom
jacobperron merged 4 commits intorollingfrom
Conversation
This allows us to forward a dependency on action_msgs for users and avoid a dependency cycle. Connected to ros2/rosidl_defaults#22 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
It is now properly included in the rosidl dependency chain. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
14 tasks
ivanpauno
approved these changes
Aug 17, 2022
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to forward a dependency on action_msgs for users and avoid a dependency cycle.
Connected to ros2/rosidl_defaults#22