chore: enable 7 previously-skipped MagicString tests by IWANABETHATGUY · Pull Request #8771 · rolldown/rolldown

IWANABETHATGUY · 2026-03-18T14:13:23Z

Summary

Enable 7 upstream MagicString tests that now pass with the slice fix from the parent PR
preserves intended order (3 tests): append/prepend ordering with slice
should allow contiguous but non-overlapping replacements (2 tests): overwrite & update
should not remove content inserted after the end of removed range (1 test)
should works (1 test): hasChanged with clone

Changes

Updated download-tests.mjs skip patterns: removed 4 entries, narrowed overlapping replacements to error if overlapping replacements so the contiguous test is no longer caught
Regenerated MagicString.test.ts with the updated skip configuration
Test count: 142 → 149 passing, 61 → 54 skipped

Test plan

All 149 MagicString tests pass
Regenerated test file from download-tests.mjs produces identical results

IWANABETHATGUY · 2026-03-18T14:13:43Z

fix: handle negative indices, overlapping ranges, and moved content in MagicString remove #8829
feat: magicString replace with regex #8802
fix: magicString prepend issues #8797
chore: enable 7 previously-skipped MagicString tests #8771 👈 (View in Graphite)
fix: handle reversed slice ranges with moved content #8750
chore: enable all test for reset category in MagicString.test.ts #8749 : 1 other dependent PR (#8753 )
feat: add indentExclusionRanges property to MagicString #8746
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

IWANABETHATGUY · 2026-03-19T13:35:20Z

Merge activity

Mar 19, 1:35 PM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 19, 4:18 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Mar 19, 4:24 PM UTC: Merged by the Graphite merge queue.

github-actions · 2026-03-19T13:47:11Z

Benchmarks Rust

target: fix/magic-string-slice(82b1f04)
pr: 03-18-chore_enable_more_test_in_magic-string.test.js(fb17e24)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     70.0±3.71ms        ? ?/sec    1.00     69.3±2.74ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04     80.8±3.89ms        ? ?/sec    1.00     77.8±3.54ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    149.7±6.23ms        ? ?/sec    1.00    146.4±4.61ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    171.4±7.11ms        ? ?/sec    1.00    167.5±5.86ms        ? ?/sec
bundle/bundle@threejs                                        1.00     64.8±2.33ms        ? ?/sec    1.00     64.8±3.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     77.1±4.29ms        ? ?/sec    1.00     76.9±3.26ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00   696.0±12.10ms        ? ?/sec    1.01   699.9±12.44ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00   811.8±12.94ms        ? ?/sec    1.00   808.6±12.10ms        ? ?/sec

codspeed-hq · 2026-03-19T13:57:12Z

Merging this PR will not alter performance

✅ 6 untouched benchmarks
⏩ 8 skipped benchmarks¹

_{Comparing 03-18-chore_enable_more_test_in_magic-string.test.js (fb17e24) with main (bc4206d)²}

8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on fix/magic-string-slice (bc4206d) during the generation of this report, so main (bc4206d) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

netlify · 2026-03-19T14:17:44Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`89f0938`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69bc220a7fcee2000814012e

## Summary - Enable 7 upstream MagicString tests that now pass with the slice fix from the parent PR - **preserves intended order** (3 tests): append/prepend ordering with slice - **should allow contiguous but non-overlapping replacements** (2 tests): overwrite & update - **should not remove content inserted after the end of removed range** (1 test) - **should works** (1 test): hasChanged with clone ## Changes - Updated download-tests.mjs skip patterns: removed 4 entries, narrowed overlapping replacements to error if overlapping replacements so the contiguous test is no longer caught - Regenerated MagicString.test.ts with the updated skip configuration - Test count: 142 → 149 passing, 61 → 54 skipped ## Test plan - [x] All 149 MagicString tests pass - [x] Regenerated test file from download-tests.mjs produces identical results

@IWANABETHATGUY

## [1.0.0-rc.11] - 2026-03-23 ### 🚀 Features - magicString replace with regex (#8802) by @IWANABETHATGUY - support `output.sourcemapExcludeSources` option (#8828) by @sapphi-red - support `getIndentString` in MagicString (#8775) by @IWANABETHATGUY - MagicString ignoreList support (#8773) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: remove `pluginName` from `MinimalPluginContext` (#8864) by @sapphi-red - do not report eval?.() as direct eval (#8860) by @IWANABETHATGUY - handle negative indices, overlapping ranges, and moved content in MagicString remove (#8829) by @IWANABETHATGUY - enable arbitrary_precision for serde_json to fix JSON float parsing (#8848) by @elderapo - resolve TypeScript lint errors (#8841) by @Boshen - avoid panic on multi-byte UTF-8 chars in hash placeholder iterator (#8790) by @shulaoda - ci: skip failing vite build watch raw query test (#8840) by @Boshen - ci: use step-level env override to unset VITE_PLUS_CLI_BIN in vite tests (#8838) by @Boshen - ci: move vite tests into CI workflow by @Boshen - ci: unset all VITE_PLUS_* env vars in vite-tests workflow (#8837) by @Boshen - test: skip watch CLI tests on Windows (#8830) by @Boshen - ci: unset VITE_PLUS_CLI_BIN in vite-tests workflow (#8832) by @Boshen - remove redundant bare side-effect imports in entry/facade chunks (#8804) by @h-a-n-a - magicString prepend issues (#8797) by @IWANABETHATGUY - ci: use `vpx` instead of `vp exec` for `pkg-pr-new` (#8827) by @Boshen - set `order` for callable plugins (#8815) by @sapphi-red - handle reversed slice ranges with moved content (#8750) by @IWANABETHATGUY - update emnapi to latest to avoid version mismatch (#8781) by @sapphi-red - external.md on Windows OS (#8780) by @bddjr - align MagicString length/isEmpty with reference magic-string (#8776) by @IWANABETHATGUY ### 🚜 Refactor - extract canonical_ref_resolving_namespace helper (#8836) by @Boshen ### 📚 Documentation - improve external examples for cross-platform correctness (#8786) by @hyf0-agent - update reference to transform function in plugin API documentation (#8778) by @zOadT ### ⚡ Performance - reduce timing of `dervie_entries_aware_chunk_name` (#8847) by @AliceLanniste - bench: remove redundant sourcemap benchmark cases (#8825) by @Boshen - reduce intermediate allocations in `collapse_sourcemaps` (#8821) by @Boshen - enable parallel AST cloning on macOS (#8814) by @Boshen ### 🧪 Testing - watch: use polling watcher and retry for watch error test (#8772) by @sapphi-red ### ⚙️ Miscellaneous Tasks - justfile: skip setup-vite-plus if vp is already installed (#8862) by @Boshen - add expectWarning option to test config (#8861) by @IWANABETHATGUY - justfile: support windows for `just setup` (#8846) by @AliceLanniste - deps: update rust crates (#8852) by @renovate[bot] - deps: update endbug/version-check action to v3 (#8855) by @renovate[bot] - deps: update github-actions (#8853) by @renovate[bot] - deps: update dependency vitepress to v2.0.0-alpha.17 (#8854) by @renovate[bot] - deps: update npm packages (#8851) by @renovate[bot] - bench: use mimalloc as global allocator in bench crate (#8844) by @IWANABETHATGUY - reuse native build artifact in node-validation job (#8826) by @Boshen - speed up CodSpeed benchmark build by disabling LTO (#8824) by @Boshen - remove redundant critcmp benchmark job (#8823) by @Boshen - deps: update rust crate oxc_sourcemap to v6.1.0 (#8785) by @renovate[bot] - node: migrate oxlint and oxfmt to Vite+ (#8813) by @Boshen - revert namespace runners for release build jobs (#8820) by @Boshen - migrate runners to namespace (#8819) by @Boshen - test: relax test utils path assertion to support git worktrees (#8816) by @younggglcy - rename `examples/lazy` to `examples/lazy-compilation` (#8789) by @shulaoda - improve "needs reproduction" wording by @Boshen - deps: update dependency oxlint-tsgolint to v0.17.1 (#8807) by @renovate[bot] - enable 7 previously-skipped MagicString tests (#8771) by @IWANABETHATGUY - upgrade oxc to 0.121.0 (#8784) by @shulaoda - increase Windows dev drive size from 12GB to 20GB (#8779) by @Copilot ### ❤️ New Contributors * @elderapo made their first contribution in [#8848](#8848) * @younggglcy made their first contribution in [#8816](#8816) * @bddjr made their first contribution in [#8780](#8780) * @zOadT made their first contribution in [#8778](#8778) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

@IWANABETHATGUY

## [1.0.0-rc.11] - 2026-03-23 ### 🚀 Features - magicString replace with regex (#8802) by @IWANABETHATGUY - support `output.sourcemapExcludeSources` option (#8828) by @sapphi-red - support `getIndentString` in MagicString (#8775) by @IWANABETHATGUY - MagicString ignoreList support (#8773) by @IWANABETHATGUY ### 🐛 Bug Fixes - forward test filters through vp run (#8870) by @younggglcy - types: remove `pluginName` from `MinimalPluginContext` (#8864) by @sapphi-red - do not report eval?.() as direct eval (#8860) by @IWANABETHATGUY - handle negative indices, overlapping ranges, and moved content in MagicString remove (#8829) by @IWANABETHATGUY - enable arbitrary_precision for serde_json to fix JSON float parsing (#8848) by @elderapo - resolve TypeScript lint errors (#8841) by @Boshen - avoid panic on multi-byte UTF-8 chars in hash placeholder iterator (#8790) by @shulaoda - ci: skip failing vite build watch raw query test (#8840) by @Boshen - ci: use step-level env override to unset VITE_PLUS_CLI_BIN in vite tests (#8838) by @Boshen - ci: move vite tests into CI workflow by @Boshen - ci: unset all VITE_PLUS_* env vars in vite-tests workflow (#8837) by @Boshen - test: skip watch CLI tests on Windows (#8830) by @Boshen - ci: unset VITE_PLUS_CLI_BIN in vite-tests workflow (#8832) by @Boshen - remove redundant bare side-effect imports in entry/facade chunks (#8804) by @h-a-n-a - magicString prepend issues (#8797) by @IWANABETHATGUY - ci: use `vpx` instead of `vp exec` for `pkg-pr-new` (#8827) by @Boshen - set `order` for callable plugins (#8815) by @sapphi-red - handle reversed slice ranges with moved content (#8750) by @IWANABETHATGUY - update emnapi to latest to avoid version mismatch (#8781) by @sapphi-red - external.md on Windows OS (#8780) by @bddjr - align MagicString length/isEmpty with reference magic-string (#8776) by @IWANABETHATGUY ### 🚜 Refactor - extract canonical_ref_resolving_namespace helper (#8836) by @Boshen ### 📚 Documentation - improve external examples for cross-platform correctness (#8786) by @hyf0-agent - update reference to transform function in plugin API documentation (#8778) by @zOadT ### ⚡ Performance - reduce timing of `dervie_entries_aware_chunk_name` (#8847) by @AliceLanniste - bench: remove redundant sourcemap benchmark cases (#8825) by @Boshen - reduce intermediate allocations in `collapse_sourcemaps` (#8821) by @Boshen - enable parallel AST cloning on macOS (#8814) by @Boshen ### 🧪 Testing - watch: use polling watcher and retry for watch error test (#8772) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency @oxc-project/types to v0.122.0 (#8873) by @renovate[bot] - publish-to-npm: use correct vp pm publish (#8871) by @shulaoda - justfile: skip setup-vite-plus if vp is already installed (#8862) by @Boshen - add expectWarning option to test config (#8861) by @IWANABETHATGUY - justfile: support windows for `just setup` (#8846) by @AliceLanniste - deps: update rust crates (#8852) by @renovate[bot] - deps: update endbug/version-check action to v3 (#8855) by @renovate[bot] - deps: update github-actions (#8853) by @renovate[bot] - deps: update dependency vitepress to v2.0.0-alpha.17 (#8854) by @renovate[bot] - deps: update npm packages (#8851) by @renovate[bot] - bench: use mimalloc as global allocator in bench crate (#8844) by @IWANABETHATGUY - reuse native build artifact in node-validation job (#8826) by @Boshen - speed up CodSpeed benchmark build by disabling LTO (#8824) by @Boshen - remove redundant critcmp benchmark job (#8823) by @Boshen - deps: update rust crate oxc_sourcemap to v6.1.0 (#8785) by @renovate[bot] - node: migrate oxlint and oxfmt to Vite+ (#8813) by @Boshen - revert namespace runners for release build jobs (#8820) by @Boshen - migrate runners to namespace (#8819) by @Boshen - test: relax test utils path assertion to support git worktrees (#8816) by @younggglcy - rename `examples/lazy` to `examples/lazy-compilation` (#8789) by @shulaoda - improve "needs reproduction" wording by @Boshen - deps: update dependency oxlint-tsgolint to v0.17.1 (#8807) by @renovate[bot] - enable 7 previously-skipped MagicString tests (#8771) by @IWANABETHATGUY - upgrade oxc to 0.121.0 (#8784) by @shulaoda - increase Windows dev drive size from 12GB to 20GB (#8779) by @Copilot ### ❤️ New Contributors * @younggglcy made their first contribution in [#8870](#8870) * @elderapo made their first contribution in [#8848](#8848) * @bddjr made their first contribution in [#8780](#8780) * @zOadT made their first contribution in [#8778](#8778) --------- Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned IWANABETHATGUY Mar 18, 2026

IWANABETHATGUY mentioned this pull request Mar 18, 2026

fix: handle reversed slice ranges with moved content #8750

Merged

IWANABETHATGUY changed the title ~~chore: enable more test in magic-string.test.js~~ chore: enable 7 previously-skipped MagicString tests Mar 18, 2026

IWANABETHATGUY force-pushed the 03-18-chore_enable_more_test_in_magic-string.test.js branch from b253255 to fb17e24 Compare March 18, 2026 14:21

IWANABETHATGUY force-pushed the fix/magic-string-slice branch 2 times, most recently from ede9b53 to 82b1f04 Compare March 19, 2026 13:33

IWANABETHATGUY marked this pull request as ready for review March 19, 2026 13:34

IWANABETHATGUY force-pushed the 03-18-chore_enable_more_test_in_magic-string.test.js branch from fb17e24 to 875bdf4 Compare March 19, 2026 13:34

IWANABETHATGUY added the graphite: merge-when-ready label Mar 19, 2026

IWANABETHATGUY requested review from hyf0 and shulaoda March 19, 2026 13:34

IWANABETHATGUY force-pushed the fix/magic-string-slice branch from 82b1f04 to c339c85 Compare March 19, 2026 13:37

IWANABETHATGUY force-pushed the 03-18-chore_enable_more_test_in_magic-string.test.js branch from 875bdf4 to a657101 Compare March 19, 2026 13:37

IWANABETHATGUY mentioned this pull request Mar 19, 2026

fix: magicString prepend issues #8797

Merged

3 tasks

graphite-app bot changed the base branch from fix/magic-string-slice to graphite-base/8771 March 19, 2026 13:58

graphite-app bot force-pushed the graphite-base/8771 branch from c339c85 to ec68fd7 Compare March 19, 2026 14:15

graphite-app bot force-pushed the 03-18-chore_enable_more_test_in_magic-string.test.js branch from a657101 to bb4acec Compare March 19, 2026 14:16

graphite-app bot changed the base branch from graphite-base/8771 to main March 19, 2026 14:16

graphite-app bot force-pushed the 03-18-chore_enable_more_test_in_magic-string.test.js branch from bb4acec to 7156f1a Compare March 19, 2026 14:16

hyf0 approved these changes Mar 19, 2026

View reviewed changes

IWANABETHATGUY mentioned this pull request Mar 19, 2026

feat: magicString replace with regex #8802

Merged

graphite-app bot force-pushed the 03-18-chore_enable_more_test_in_magic-string.test.js branch from 7156f1a to 89f0938 Compare March 19, 2026 16:19

graphite-app bot removed the graphite: merge-when-ready label Mar 19, 2026

graphite-app bot merged commit 89f0938 into main Mar 19, 2026
36 of 38 checks passed

graphite-app bot deleted the 03-18-chore_enable_more_test_in_magic-string.test.js branch March 19, 2026 16:24

IWANABETHATGUY mentioned this pull request Mar 21, 2026

fix: handle negative indices, overlapping ranges, and moved content in MagicString remove #8829

Merged

github-actions bot mentioned this pull request Mar 23, 2026

release: v1.0.0-rc.11 #8868

Merged

This was referenced Mar 23, 2026

release: v1.0.0-rc.11 #8872

Closed

release: v1.0.0-rc.11 #8876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: enable 7 previously-skipped MagicString tests#8771

chore: enable 7 previously-skipped MagicString tests#8771
graphite-app[bot] merged 1 commit intomainfrom
03-18-chore_enable_more_test_in_magic-string.test.js

IWANABETHATGUY commented Mar 18, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Mar 18, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Mar 19, 2026 •

edited by graphite-app bot

Loading

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

codspeed-hq bot commented Mar 19, 2026

Uh oh!

netlify bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

IWANABETHATGUY commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

IWANABETHATGUY commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

IWANABETHATGUY commented Mar 19, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

github-actions bot commented Mar 19, 2026

Benchmarks Rust

Uh oh!

codspeed-hq bot commented Mar 19, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

netlify bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Mar 18, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 18, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 19, 2026 •

edited by graphite-app bot

Loading

netlify bot commented Mar 19, 2026 •

edited

Loading