fix: align MagicString length/isEmpty with reference magic-string by IWANABETHATGUY · Pull Request #8776 · rolldown/rolldown

IWANABETHATGUY · 2026-03-18T17:25:51Z

Summary

Fix len() to only count chunk content (excluding global intro/outro from prepend/append), matching reference magic-string behavior
Fix isEmpty() to check for whitespace-only content using .trim() instead of checking for zero length
Fix to_string() size hint to still use full output length
Unskip the isEmpty and length tests

IWANABETHATGUY · 2026-03-18T17:26:08Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-03-18T17:53:30Z

Benchmarks Rust

target: 03-19-feat_magicstring_get_indent_string(0ec0ae2)
pr: 03-19-fix_magicstring_length(3878d89)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     62.8±2.20ms        ? ?/sec    1.05     65.8±3.06ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     70.1±1.30ms        ? ?/sec    1.05     73.3±2.10ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    135.9±2.45ms        ? ?/sec    1.00    136.0±2.13ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    153.6±2.94ms        ? ?/sec    1.02    156.7±4.33ms        ? ?/sec
bundle/bundle@threejs                                        1.00     60.0±2.29ms        ? ?/sec    1.01     60.5±2.54ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     70.6±2.26ms        ? ?/sec    1.00     70.1±1.08ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    694.2±5.22ms        ? ?/sec    1.01    703.4±4.89ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    801.4±5.57ms        ? ?/sec    1.00    801.6±5.45ms        ? ?/sec

codspeed-hq · 2026-03-18T18:01:20Z

Merging this PR will not alter performance

✅ 6 untouched benchmarks
⏩ 8 skipped benchmarks¹

_{Comparing 03-19-fix_magicstring_length (3878d89) with 03-19-feat_magicstring_get_indent_string (0ec0ae2)}

8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

graphite-app · 2026-03-19T02:27:37Z

Merge activity

Mar 19, 2:27 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Mar 19, 2:34 AM UTC: Merged by the Graphite merge queue.

) ## Summary - Fix `len()` to only count chunk content (excluding global intro/outro from `prepend`/`append`), matching reference `magic-string` behavior - Fix `isEmpty()` to check for whitespace-only content using `.trim()` instead of checking for zero length - Fix `to_string()` size hint to still use full output length - Unskip the `isEmpty` and `length` tests

@IWANABETHATGUY

## [1.0.0-rc.11] - 2026-03-23 ### 🚀 Features - magicString replace with regex (#8802) by @IWANABETHATGUY - support `output.sourcemapExcludeSources` option (#8828) by @sapphi-red - support `getIndentString` in MagicString (#8775) by @IWANABETHATGUY - MagicString ignoreList support (#8773) by @IWANABETHATGUY ### 🐛 Bug Fixes - types: remove `pluginName` from `MinimalPluginContext` (#8864) by @sapphi-red - do not report eval?.() as direct eval (#8860) by @IWANABETHATGUY - handle negative indices, overlapping ranges, and moved content in MagicString remove (#8829) by @IWANABETHATGUY - enable arbitrary_precision for serde_json to fix JSON float parsing (#8848) by @elderapo - resolve TypeScript lint errors (#8841) by @Boshen - avoid panic on multi-byte UTF-8 chars in hash placeholder iterator (#8790) by @shulaoda - ci: skip failing vite build watch raw query test (#8840) by @Boshen - ci: use step-level env override to unset VITE_PLUS_CLI_BIN in vite tests (#8838) by @Boshen - ci: move vite tests into CI workflow by @Boshen - ci: unset all VITE_PLUS_* env vars in vite-tests workflow (#8837) by @Boshen - test: skip watch CLI tests on Windows (#8830) by @Boshen - ci: unset VITE_PLUS_CLI_BIN in vite-tests workflow (#8832) by @Boshen - remove redundant bare side-effect imports in entry/facade chunks (#8804) by @h-a-n-a - magicString prepend issues (#8797) by @IWANABETHATGUY - ci: use `vpx` instead of `vp exec` for `pkg-pr-new` (#8827) by @Boshen - set `order` for callable plugins (#8815) by @sapphi-red - handle reversed slice ranges with moved content (#8750) by @IWANABETHATGUY - update emnapi to latest to avoid version mismatch (#8781) by @sapphi-red - external.md on Windows OS (#8780) by @bddjr - align MagicString length/isEmpty with reference magic-string (#8776) by @IWANABETHATGUY ### 🚜 Refactor - extract canonical_ref_resolving_namespace helper (#8836) by @Boshen ### 📚 Documentation - improve external examples for cross-platform correctness (#8786) by @hyf0-agent - update reference to transform function in plugin API documentation (#8778) by @zOadT ### ⚡ Performance - reduce timing of `dervie_entries_aware_chunk_name` (#8847) by @AliceLanniste - bench: remove redundant sourcemap benchmark cases (#8825) by @Boshen - reduce intermediate allocations in `collapse_sourcemaps` (#8821) by @Boshen - enable parallel AST cloning on macOS (#8814) by @Boshen ### 🧪 Testing - watch: use polling watcher and retry for watch error test (#8772) by @sapphi-red ### ⚙️ Miscellaneous Tasks - justfile: skip setup-vite-plus if vp is already installed (#8862) by @Boshen - add expectWarning option to test config (#8861) by @IWANABETHATGUY - justfile: support windows for `just setup` (#8846) by @AliceLanniste - deps: update rust crates (#8852) by @renovate[bot] - deps: update endbug/version-check action to v3 (#8855) by @renovate[bot] - deps: update github-actions (#8853) by @renovate[bot] - deps: update dependency vitepress to v2.0.0-alpha.17 (#8854) by @renovate[bot] - deps: update npm packages (#8851) by @renovate[bot] - bench: use mimalloc as global allocator in bench crate (#8844) by @IWANABETHATGUY - reuse native build artifact in node-validation job (#8826) by @Boshen - speed up CodSpeed benchmark build by disabling LTO (#8824) by @Boshen - remove redundant critcmp benchmark job (#8823) by @Boshen - deps: update rust crate oxc_sourcemap to v6.1.0 (#8785) by @renovate[bot] - node: migrate oxlint and oxfmt to Vite+ (#8813) by @Boshen - revert namespace runners for release build jobs (#8820) by @Boshen - migrate runners to namespace (#8819) by @Boshen - test: relax test utils path assertion to support git worktrees (#8816) by @younggglcy - rename `examples/lazy` to `examples/lazy-compilation` (#8789) by @shulaoda - improve "needs reproduction" wording by @Boshen - deps: update dependency oxlint-tsgolint to v0.17.1 (#8807) by @renovate[bot] - enable 7 previously-skipped MagicString tests (#8771) by @IWANABETHATGUY - upgrade oxc to 0.121.0 (#8784) by @shulaoda - increase Windows dev drive size from 12GB to 20GB (#8779) by @Copilot ### ❤️ New Contributors * @elderapo made their first contribution in [#8848](#8848) * @younggglcy made their first contribution in [#8816](#8816) * @bddjr made their first contribution in [#8780](#8780) * @zOadT made their first contribution in [#8778](#8778) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

@IWANABETHATGUY

## [1.0.0-rc.11] - 2026-03-23 ### 🚀 Features - magicString replace with regex (#8802) by @IWANABETHATGUY - support `output.sourcemapExcludeSources` option (#8828) by @sapphi-red - support `getIndentString` in MagicString (#8775) by @IWANABETHATGUY - MagicString ignoreList support (#8773) by @IWANABETHATGUY ### 🐛 Bug Fixes - forward test filters through vp run (#8870) by @younggglcy - types: remove `pluginName` from `MinimalPluginContext` (#8864) by @sapphi-red - do not report eval?.() as direct eval (#8860) by @IWANABETHATGUY - handle negative indices, overlapping ranges, and moved content in MagicString remove (#8829) by @IWANABETHATGUY - enable arbitrary_precision for serde_json to fix JSON float parsing (#8848) by @elderapo - resolve TypeScript lint errors (#8841) by @Boshen - avoid panic on multi-byte UTF-8 chars in hash placeholder iterator (#8790) by @shulaoda - ci: skip failing vite build watch raw query test (#8840) by @Boshen - ci: use step-level env override to unset VITE_PLUS_CLI_BIN in vite tests (#8838) by @Boshen - ci: move vite tests into CI workflow by @Boshen - ci: unset all VITE_PLUS_* env vars in vite-tests workflow (#8837) by @Boshen - test: skip watch CLI tests on Windows (#8830) by @Boshen - ci: unset VITE_PLUS_CLI_BIN in vite-tests workflow (#8832) by @Boshen - remove redundant bare side-effect imports in entry/facade chunks (#8804) by @h-a-n-a - magicString prepend issues (#8797) by @IWANABETHATGUY - ci: use `vpx` instead of `vp exec` for `pkg-pr-new` (#8827) by @Boshen - set `order` for callable plugins (#8815) by @sapphi-red - handle reversed slice ranges with moved content (#8750) by @IWANABETHATGUY - update emnapi to latest to avoid version mismatch (#8781) by @sapphi-red - external.md on Windows OS (#8780) by @bddjr - align MagicString length/isEmpty with reference magic-string (#8776) by @IWANABETHATGUY ### 🚜 Refactor - extract canonical_ref_resolving_namespace helper (#8836) by @Boshen ### 📚 Documentation - improve external examples for cross-platform correctness (#8786) by @hyf0-agent - update reference to transform function in plugin API documentation (#8778) by @zOadT ### ⚡ Performance - reduce timing of `dervie_entries_aware_chunk_name` (#8847) by @AliceLanniste - bench: remove redundant sourcemap benchmark cases (#8825) by @Boshen - reduce intermediate allocations in `collapse_sourcemaps` (#8821) by @Boshen - enable parallel AST cloning on macOS (#8814) by @Boshen ### 🧪 Testing - watch: use polling watcher and retry for watch error test (#8772) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update dependency @oxc-project/types to v0.122.0 (#8873) by @renovate[bot] - publish-to-npm: use correct vp pm publish (#8871) by @shulaoda - justfile: skip setup-vite-plus if vp is already installed (#8862) by @Boshen - add expectWarning option to test config (#8861) by @IWANABETHATGUY - justfile: support windows for `just setup` (#8846) by @AliceLanniste - deps: update rust crates (#8852) by @renovate[bot] - deps: update endbug/version-check action to v3 (#8855) by @renovate[bot] - deps: update github-actions (#8853) by @renovate[bot] - deps: update dependency vitepress to v2.0.0-alpha.17 (#8854) by @renovate[bot] - deps: update npm packages (#8851) by @renovate[bot] - bench: use mimalloc as global allocator in bench crate (#8844) by @IWANABETHATGUY - reuse native build artifact in node-validation job (#8826) by @Boshen - speed up CodSpeed benchmark build by disabling LTO (#8824) by @Boshen - remove redundant critcmp benchmark job (#8823) by @Boshen - deps: update rust crate oxc_sourcemap to v6.1.0 (#8785) by @renovate[bot] - node: migrate oxlint and oxfmt to Vite+ (#8813) by @Boshen - revert namespace runners for release build jobs (#8820) by @Boshen - migrate runners to namespace (#8819) by @Boshen - test: relax test utils path assertion to support git worktrees (#8816) by @younggglcy - rename `examples/lazy` to `examples/lazy-compilation` (#8789) by @shulaoda - improve "needs reproduction" wording by @Boshen - deps: update dependency oxlint-tsgolint to v0.17.1 (#8807) by @renovate[bot] - enable 7 previously-skipped MagicString tests (#8771) by @IWANABETHATGUY - upgrade oxc to 0.121.0 (#8784) by @shulaoda - increase Windows dev drive size from 12GB to 20GB (#8779) by @Copilot ### ❤️ New Contributors * @younggglcy made their first contribution in [#8870](#8870) * @elderapo made their first contribution in [#8848](#8848) * @bddjr made their first contribution in [#8780](#8780) * @zOadT made their first contribution in [#8778](#8778) --------- Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned IWANABETHATGUY Mar 18, 2026

IWANABETHATGUY mentioned this pull request Mar 18, 2026

feat: MagicString ignoreList support #8773

Merged

IWANABETHATGUY mentioned this pull request Mar 18, 2026

feat: support getIndentString in MagicString #8775

Merged

IWANABETHATGUY changed the title ~~fix: magicstring length~~ fix: align MagicString length/isEmpty with reference magic-string Mar 18, 2026

IWANABETHATGUY marked this pull request as ready for review March 18, 2026 17:38

shulaoda approved these changes Mar 19, 2026

View reviewed changes

IWANABETHATGUY added the graphite: merge-when-ready label Mar 19, 2026

graphite-app bot force-pushed the 03-19-feat_magicstring_get_indent_string branch from 0ec0ae2 to 3b8013e Compare March 19, 2026 02:28

graphite-app bot force-pushed the 03-19-fix_magicstring_length branch from 3878d89 to cbb9c59 Compare March 19, 2026 02:29

Base automatically changed from 03-19-feat_magicstring_get_indent_string to main March 19, 2026 02:33

graphite-app bot removed the graphite: merge-when-ready label Mar 19, 2026

graphite-app bot merged commit cbb9c59 into main Mar 19, 2026
29 checks passed

graphite-app bot deleted the 03-19-fix_magicstring_length branch March 19, 2026 02:34

github-actions bot mentioned this pull request Mar 23, 2026

release: v1.0.0-rc.11 #8868

Merged

This was referenced Mar 23, 2026

release: v1.0.0-rc.11 #8872

Closed

release: v1.0.0-rc.11 #8876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: align MagicString length/isEmpty with reference magic-string#8776

fix: align MagicString length/isEmpty with reference magic-string#8776
graphite-app[bot] merged 1 commit intomainfrom
03-19-fix_magicstring_length

IWANABETHATGUY commented Mar 18, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Mar 18, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

codspeed-hq bot commented Mar 18, 2026

Uh oh!

graphite-app bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

IWANABETHATGUY commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

IWANABETHATGUY commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Mar 18, 2026

Benchmarks Rust

Uh oh!

codspeed-hq bot commented Mar 18, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

graphite-app bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Mar 18, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 18, 2026 •

edited

Loading

graphite-app bot commented Mar 19, 2026 •

edited

Loading