refactor: simplify string repeat in guess_indentor by IWANABETHATGUY · Pull Request #8753 · rolldown/rolldown

IWANABETHATGUY · 2026-03-17T13:11:54Z

Description:

Replaces a manual String::with_capacity + loop with " ".repeat() in guess_indentor for cleaner, more idiomatic Rust.

IWANABETHATGUY · 2026-03-17T13:12:12Z

refactor: simplify string repeat in guess_indentor #8753 👈 (View in Graphite)
chore: enable all test for reset category in MagicString.test.ts #8749 : 1 other dependent PR (#8750 )
feat: add indentExclusionRanges property to MagicString #8746
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-03-17T13:37:59Z

Benchmarks Rust

target: main(529f54b)
pr: refactor/simplify-repeat-in-indent(1806f3e)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.1±1.79ms        ? ?/sec    1.00     67.1±1.43ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     77.8±2.93ms        ? ?/sec    1.00     75.3±1.94ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    151.3±5.86ms        ? ?/sec    1.02    153.9±6.84ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    169.6±4.32ms        ? ?/sec    1.04    176.4±6.13ms        ? ?/sec
bundle/bundle@threejs                                        1.00     62.9±2.25ms        ? ?/sec    1.03     65.0±3.82ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     75.0±5.07ms        ? ?/sec    1.00     73.4±3.00ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    718.7±9.50ms        ? ?/sec    1.00    717.1±8.98ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00   822.3±10.70ms        ? ?/sec    1.00    820.5±9.27ms        ? ?/sec

codspeed-hq · 2026-03-17T13:45:02Z

Merging this PR will not alter performance

✅ 6 untouched benchmarks
⏩ 8 skipped benchmarks¹

_{Comparing refactor/simplify-repeat-in-indent (1806f3e) with main (638ce1e)²}

8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (529f54b) during the generation of this report, so 638ce1e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

netlify · 2026-03-17T14:56:38Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`2bfe619`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69b97913d9658d00083f3053

graphite-app · 2026-03-17T15:51:32Z

Merge activity

Mar 17, 3:51 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Mar 17, 4:00 PM UTC: Merged by the Graphite merge queue.

**Description:** Replaces a manual `String::with_capacity` + loop with `" ".repeat()` in `guess_indentor` for cleaner, more idiomatic Rust.

@IWANABETHATGUY

## [1.0.0-rc.10] - 2026-03-18 ### 🚀 Features - add indentExclusionRanges property to MagicString (#8746) by @IWANABETHATGUY - expose `oxcRuntimePlugin` (#8654) by @sapphi-red - rust: make bundler generic over FileSystem for in-memory benchmarks (#8652) by @Boshen ### 🐛 Bug Fixes - rolldown_plugin_vite_dynamic_import_vars: align dynamic import fast check with Vite (#8760) by @shulaoda - renamer: handle existing bindings in nested scopes when finding unique names (#8741) by @drewolson - pass `yarn_pnp` option where needed (#8736) by @sapphi-red - preserve optional chaining in namespace member expr rewrite (#8712) by @Copilot - correct UTF-16 index handling in native MagicString (#8693) by @IWANABETHATGUY - mark failing doctests as ignore (#8700) by @Boshen - prevent may_partial_namespace from leaking through include_module (#8682) by @IWANABETHATGUY - ci: bump native-build cache key to invalidate stale napi-rs artifacts (#8678) by @Boshen - `comments.annotation: false` breaking tree-shaking (#8657) by @IWANABETHATGUY - validate filenames for NUL bytes from chunkFileNames/entryFileNames (#8644) by @IWANABETHATGUY - dce-only minify should not set NODE_ENV to production (#8651) by @IWANABETHATGUY ### 🚜 Refactor - rust: remove dead `CrossModuleOptimizationConfig::side_effects_free_function_optimization` (#8673) by @Dunqing - rust: simplify `cross_module_optimization` by removing redundant scope tracking (#8672) by @Dunqing - simplify string repeat in guess_indentor (#8753) by @IWANABETHATGUY - consolidate custom magic-string tests into one file (#8696) by @IWANABETHATGUY - extract CJS bailout checks from include_symbol (#8683) by @IWANABETHATGUY - rust: remove `BindingIdentifierExt` to use `BindingIdentifier::symbol_id()` instead (#8667) by @Dunqing - bench: add bench_preset helper and inline presets (#8658) by @Boshen - rust: filter external modules from entries instead of mapping bit positions (#8637) by @Dunqing ### 📚 Documentation - clarify watch mode behavior and its limitations (#8751) by @sapphi-red - add external link icon to GitHub button in Hero section (#8731) by @thisisnkc - guide: clarify that `inject` option is only conceptually similar to esbuild's one (#8743) by @sapphi-red - meta/design: add `devtools.md` (#8663) by @hyf0 - add viteplus alpha announcement banner (#8668) by @shulaoda ### ⚡ Performance - rolldown: some minor perf optimization found by autoresearch (#8730) by @Brooooooklyn - replace Vec allocation with lazy iterator in find_hash_placeholders (#8703) by @Boshen - replace TypedDashMap with TypedMap in CustomField (#8708) by @Boshen - bench: remove scan benchmark binary to halve LTO link time (#8694) by @Boshen ### 🧪 Testing - watch: increase timeout for error output (#8766) by @sapphi-red - vite-tests: remove JS plugin tests (#8767) by @sapphi-red - watch: add CLI exit code test (#8752) by @sapphi-red - normalize paths on Windows even if `resolve.symlinks` is false (#8483) by @sapphi-red ### ⚙️ Miscellaneous Tasks - correct comment in bundle-analyzer-plugin.ts (#8770) by @origami-z - upgrade oxc to 0.120.0 (#8764) by @Boshen - enable all test for `reset` category in MagicString.test.ts (#8749) by @IWANABETHATGUY - deps: update test262 submodule for tests (#8742) by @sapphi-red - deps: update oxc apps (#8734) by @renovate[bot] - deps: update softprops/action-gh-release action to v2.6.1 (#8724) by @renovate[bot] - deps: update npm packages (major) (#8722) by @renovate[bot] - deps: update github-actions (major) (#8721) by @renovate[bot] - deps: update softprops/action-gh-release action to v2.6.0 (#8720) by @renovate[bot] - deps: update npm packages (#8718) by @renovate[bot] - deps: update rust crates (#8717) by @renovate[bot] - deps: update github-actions (#8716) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.17.0 (#8713) by @renovate[bot] - deps: bump cargo-shear to v1.11.2 (#8711) by @Boshen - use org level `CODE_OF_CONDUCT.md` (#8706) by @sapphi-red - fix cache key mismatch and remove redundant cache saves (#8695) by @Boshen - deps: update oxc apps (#8692) by @renovate[bot] - deps: update oxc apps (#8649) by @renovate[bot] - should do matrix out side of reusable workflows 2 (#8691) by @hyf0 - should do matrix out side of reusable workflows (#8690) by @hyf0 - deps: update dependency rolldown-plugin-dts to v0.22.5 (#8689) by @renovate[bot] - upgrade oxc to 0.119.0 and oxc_resolver to 11.19.1 (#8686) by @Boshen - correct if condition of `type-check` job (#8677) by @hyf0 - Gate CI type-check job on node changes (#8669) by @Copilot - benchmark: improve codspeed build (#8665) by @Boshen - deps: update oxc to v0.118.0 (#8650) by @renovate[bot] - deps: update crate-ci/typos action to v1.44.0 (#8647) by @renovate[bot] - deps: update oxc resolver to v11.19.1 (#8646) by @renovate[bot] - deps: update dependency rust to v1.94.0 (#8648) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.22.4 (#8645) by @renovate[bot] ### ◀️ Revert - Revert "ci: Gate CI type-check job on node changes" (#8674) by @hyf0 - "chore(deps): update dependency rust to v1.94.0 (#8648)" (#8660) by @shulaoda ### ❤️ New Contributors * @origami-z made their first contribution in [#8770](#8770) * @drewolson made their first contribution in [#8741](#8741) * @thisisnkc made their first contribution in [#8731](#8731) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned IWANABETHATGUY Mar 17, 2026

This was referenced Mar 17, 2026

feat: add indentExclusionRanges property to MagicString #8746

Merged

chore: enable all test for reset category in MagicString.test.ts #8749

Merged

IWANABETHATGUY mentioned this pull request Mar 17, 2026

fix: handle reversed slice ranges with moved content #8750

Merged

IWANABETHATGUY changed the title ~~fix: magicstring slice issues~~ refactor: simplify string repeat in guess_indentor Mar 17, 2026

IWANABETHATGUY marked this pull request as ready for review March 17, 2026 13:14

IWANABETHATGUY force-pushed the refactor/simplify-repeat-in-indent branch 2 times, most recently from 4d2df1f to 3e73f3b Compare March 17, 2026 13:22

IWANABETHATGUY requested a review from hyf0 March 17, 2026 14:39

graphite-app bot changed the base branch from 03-17-chore_enable_all_eset_test_case_in_magicstring.test.js to graphite-base/8753 March 17, 2026 14:49

graphite-app bot force-pushed the graphite-base/8753 branch from 27092a7 to 529f54b Compare March 17, 2026 14:55

graphite-app bot force-pushed the refactor/simplify-repeat-in-indent branch from 3e73f3b to 52accee Compare March 17, 2026 14:55

graphite-app bot changed the base branch from graphite-base/8753 to main March 17, 2026 14:56

graphite-app bot force-pushed the refactor/simplify-repeat-in-indent branch from 52accee to 1806f3e Compare March 17, 2026 14:56

hyf0 approved these changes Mar 17, 2026

View reviewed changes

hyf0 added the graphite: merge-when-ready label Mar 17, 2026

graphite-app bot pushed a commit that referenced this pull request Mar 17, 2026

refactor: simplify string repeat in guess_indentor (#8753)

83a778a

**Description:** Replaces a manual `String::with_capacity` + loop with `" ".repeat()` in `guess_indentor` for cleaner, more idiomatic Rust.

graphite-app bot force-pushed the refactor/simplify-repeat-in-indent branch from 1806f3e to 83a778a Compare March 17, 2026 15:52

refactor: simplify string repeat in guess_indentor (#8753)

2bfe619

**Description:** Replaces a manual `String::with_capacity` + loop with `" ".repeat()` in `guess_indentor` for cleaner, more idiomatic Rust.

graphite-app bot force-pushed the refactor/simplify-repeat-in-indent branch from 83a778a to 2bfe619 Compare March 17, 2026 15:53

graphite-app bot merged commit 2bfe619 into main Mar 17, 2026
32 checks passed

graphite-app bot removed the graphite: merge-when-ready label Mar 17, 2026

github-actions bot mentioned this pull request Mar 18, 2026

release: v1.0.0-rc.10 #8759

Closed

IWANABETHATGUY mentioned this pull request Mar 18, 2026

chore: enable 7 previously-skipped MagicString tests #8771

Merged

2 tasks

github-actions bot mentioned this pull request Mar 18, 2026

release: v1.0.0-rc.10 #8774

Merged

This was referenced Mar 19, 2026

fix: magicString prepend issues #8797

Merged

feat: magicString replace with regex #8802

Merged

fix: handle negative indices, overlapping ranges, and moved content in MagicString remove #8829

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: simplify string repeat in guess_indentor#8753

refactor: simplify string repeat in guess_indentor#8753
graphite-app[bot] merged 1 commit intomainfrom
refactor/simplify-repeat-in-indent

IWANABETHATGUY commented Mar 17, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Mar 17, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

IWANABETHATGUY commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

codspeed-hq bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

netlify bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

graphite-app bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented Mar 17, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 17, 2026 •

edited

Loading

github-actions bot commented Mar 17, 2026 •

edited

Loading

codspeed-hq bot commented Mar 17, 2026 •

edited

Loading

netlify bot commented Mar 17, 2026 •

edited

Loading

graphite-app bot commented Mar 17, 2026 •

edited

Loading