Skip to content

ci(benchmark): improve codspeed build#8665

Merged
Boshen merged 1 commit intomainfrom
03-13-ci_benchmark_improve_codspeed_build
Mar 13, 2026
Merged

ci(benchmark): improve codspeed build#8665
Boshen merged 1 commit intomainfrom
03-13-ci_benchmark_improve_codspeed_build

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Mar 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 13, 2026 06:29
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 13, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit dcb8734
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69b3aebebed51d00088e371d

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Rust benchmark GitHub Actions workflow, apparently aiming to simplify the CodSpeed benchmark job configuration.

Changes:

  • Removes cargo-codspeed from the Rust tool setup step.
  • Simplifies the “build benchmark targets” step into an unnamed run step.
  • Removes the CARGO_MANIFEST_DIR environment override from the CodSpeed action step.

You can also share your feedback on Copilot code review. Take the survey.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 13, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks


Comparing 03-13-ci_benchmark_improve_codspeed_build (dcb8734) with main (7b8c6ee)

Open in CodSpeed

@github-actions
Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(7b8c6ee)
  • pr: 03-13-ci_benchmark_improve_codspeed_build(dcb8734)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.5±1.96ms        ? ?/sec    1.01     68.0±1.89ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     75.5±1.50ms        ? ?/sec    1.00     75.3±1.84ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    148.3±5.77ms        ? ?/sec    1.00    142.9±3.03ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    166.5±3.74ms        ? ?/sec    1.00    164.2±4.30ms        ? ?/sec
bundle/bundle@threejs                                        1.04     64.2±3.58ms        ? ?/sec    1.00     61.7±0.88ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     73.2±1.57ms        ? ?/sec    1.00     71.9±1.26ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    725.5±5.61ms        ? ?/sec    1.01    731.4±7.44ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    834.5±7.55ms        ? ?/sec    1.00    836.3±7.81ms        ? ?/sec
scan/scan@rome_ts                                            1.02     70.8±1.66ms        ? ?/sec    1.00     69.5±1.26ms        ? ?/sec
scan/scan@threejs                                            1.03     25.2±0.80ms        ? ?/sec    1.00     24.5±0.37ms        ? ?/sec
scan/scan@threejs10x                                         1.00    247.9±5.59ms        ? ?/sec    1.00    248.9±4.90ms        ? ?/sec

@Boshen Boshen merged commit e7de7cb into main Mar 13, 2026
55 of 57 checks passed
@Boshen Boshen deleted the 03-13-ci_benchmark_improve_codspeed_build branch March 13, 2026 07:54
This was referenced Mar 18, 2026
shulaoda added a commit that referenced this pull request Mar 18, 2026
## [1.0.0-rc.10] - 2026-03-18

### 🚀 Features

- add indentExclusionRanges property to MagicString (#8746) by @IWANABETHATGUY
- expose `oxcRuntimePlugin` (#8654) by @sapphi-red
- rust: make bundler generic over FileSystem for in-memory benchmarks (#8652) by @Boshen

### 🐛 Bug Fixes

- rolldown_plugin_vite_dynamic_import_vars: align dynamic import fast check with Vite (#8760) by @shulaoda
- renamer: handle existing bindings in nested scopes when finding unique names (#8741) by @drewolson
- pass `yarn_pnp` option where needed (#8736) by @sapphi-red
- preserve optional chaining in namespace member expr rewrite (#8712) by @Copilot
- correct UTF-16 index handling in native MagicString (#8693) by @IWANABETHATGUY
- mark failing doctests as ignore (#8700) by @Boshen
- prevent may_partial_namespace from leaking through include_module (#8682) by @IWANABETHATGUY
- ci: bump native-build cache key to invalidate stale napi-rs artifacts (#8678) by @Boshen
- `comments.annotation: false` breaking tree-shaking (#8657) by @IWANABETHATGUY
- validate filenames for NUL bytes from chunkFileNames/entryFileNames (#8644) by @IWANABETHATGUY
- dce-only minify should not set NODE_ENV to production (#8651) by @IWANABETHATGUY

### 🚜 Refactor

- rust: remove dead `CrossModuleOptimizationConfig::side_effects_free_function_optimization` (#8673) by @Dunqing
- rust: simplify `cross_module_optimization` by removing redundant scope tracking (#8672) by @Dunqing
- simplify string repeat in guess_indentor (#8753) by @IWANABETHATGUY
- consolidate custom magic-string tests into one file (#8696) by @IWANABETHATGUY
- extract CJS bailout checks from include_symbol (#8683) by @IWANABETHATGUY
- rust: remove `BindingIdentifierExt` to use `BindingIdentifier::symbol_id()` instead (#8667) by @Dunqing
- bench: add bench_preset helper and inline presets (#8658) by @Boshen
- rust: filter external modules from entries instead of mapping bit positions (#8637) by @Dunqing

### 📚 Documentation

- clarify watch mode behavior and its limitations (#8751) by @sapphi-red
- add external link icon to GitHub button in Hero section (#8731) by @thisisnkc
- guide: clarify that `inject` option is only conceptually similar to esbuild's one (#8743) by @sapphi-red
- meta/design: add `devtools.md` (#8663) by @hyf0
- add viteplus alpha announcement banner (#8668) by @shulaoda

### ⚡ Performance

- rolldown: some minor perf optimization found by autoresearch (#8730) by @Brooooooklyn
- replace Vec allocation with lazy iterator in find_hash_placeholders (#8703) by @Boshen
- replace TypedDashMap with TypedMap in CustomField (#8708) by @Boshen
- bench: remove scan benchmark binary to halve LTO link time (#8694) by @Boshen

### 🧪 Testing

- watch: increase timeout for error output (#8766) by @sapphi-red
- vite-tests: remove JS plugin tests (#8767) by @sapphi-red
- watch: add CLI exit code test (#8752) by @sapphi-red
- normalize paths on Windows even if `resolve.symlinks` is false (#8483) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- correct comment in bundle-analyzer-plugin.ts (#8770) by @origami-z
- upgrade oxc to 0.120.0 (#8764) by @Boshen
- enable all test for `reset` category in MagicString.test.ts (#8749) by @IWANABETHATGUY
- deps: update test262 submodule for tests (#8742) by @sapphi-red
- deps: update oxc apps (#8734) by @renovate[bot]
- deps: update softprops/action-gh-release action to v2.6.1 (#8724) by @renovate[bot]
- deps: update npm packages (major) (#8722) by @renovate[bot]
- deps: update github-actions (major) (#8721) by @renovate[bot]
- deps: update softprops/action-gh-release action to v2.6.0 (#8720) by @renovate[bot]
- deps: update npm packages (#8718) by @renovate[bot]
- deps: update rust crates (#8717) by @renovate[bot]
- deps: update github-actions (#8716) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.17.0 (#8713) by @renovate[bot]
- deps: bump cargo-shear to v1.11.2 (#8711) by @Boshen
- use org level `CODE_OF_CONDUCT.md` (#8706) by @sapphi-red
- fix cache key mismatch and remove redundant cache saves (#8695) by @Boshen
- deps: update oxc apps (#8692) by @renovate[bot]
- deps: update oxc apps (#8649) by @renovate[bot]
- should do matrix out side of reusable workflows 2 (#8691) by @hyf0
- should do matrix out side of reusable workflows (#8690) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.22.5 (#8689) by @renovate[bot]
- upgrade oxc to 0.119.0 and oxc_resolver to 11.19.1 (#8686) by @Boshen
- correct if condition of `type-check` job (#8677) by @hyf0
- Gate CI type-check job on node changes (#8669) by @Copilot
- benchmark: improve codspeed build (#8665) by @Boshen
- deps: update oxc to v0.118.0 (#8650) by @renovate[bot]
- deps: update crate-ci/typos action to v1.44.0 (#8647) by @renovate[bot]
- deps: update oxc resolver to v11.19.1 (#8646) by @renovate[bot]
- deps: update dependency rust to v1.94.0 (#8648) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.22.4 (#8645) by @renovate[bot]

### ◀️ Revert

- Revert "ci: Gate CI type-check job on node changes" (#8674) by @hyf0
- "chore(deps): update dependency rust to v1.94.0 (#8648)" (#8660) by @shulaoda

### ❤️ New Contributors

* @origami-z made their first contribution in [#8770](#8770)
* @drewolson made their first contribution in [#8741](#8741)
* @thisisnkc made their first contribution in [#8731](#8731)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants