chore: upgrade oxc to 0.119.0 and oxc_resolver to 11.19.1 by Boshen · Pull Request #8686 · rolldown/rolldown

Boshen · 2026-03-14T11:49:13Z

Summary

Upgrade oxc crates from 0.118.0 to 0.119.0
Upgrade oxc_resolver from 11.17.1 to 11.19.1
Upgrade npm packages (@oxc-project/runtime, @oxc-project/types, oxc-minify, oxc-parser, oxc-transform) from 0.118.0 to 0.119.0
Mark object-spread-side-effect test as expected failure due to oxc regression (object spread with getter side effects incorrectly tree-shaken)
Update ~30 test snapshots for minor codegen changes (more compact output, variable inlining)

🤖 Generated with Claude Code

socket-security · 2026-03-14T11:49:55Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@oxc-project/types@0.118.0 ⏵ 0.119.0			⁺¹
@oxc-project/runtime@0.118.0 ⏵ 0.119.0			⁺¹
oxc-minify@0.118.0 ⏵ 0.119.0			⁺¹
oxc-transform@0.118.0 ⏵ 0.119.0	^-4
oxc-parser@0.118.0 ⏵ 0.119.0	⁺¹	⁺¹	⁺¹

View full report

netlify · 2026-03-14T11:50:26Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`fe9150d`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69b54d36de66670008b85644

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9a9dae89d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/rolldown/tests/rollup/object-spread-side-effect/_config.json

- oxc, oxc_allocator, oxc_ecmascript, oxc_traverse, etc.: 0.118.0 → 0.119.0 - oxc_resolver, oxc_resolver_napi: 11.17.1 → 11.19.1 - npm packages (@oxc-project/runtime, @oxc-project/types, oxc-minify, oxc-parser, oxc-transform): 0.118.0 → 0.119.0 - Mark object-spread-side-effect test as expected failure (oxc regression) - Update test snapshots for codegen changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Upgrades the repo’s Rust and Node dependencies around the Oxc toolchain (parser/transform/minify/runtime + resolver) and updates snapshots/tests to reflect the new codegen output, including temporarily marking a known regression as an expected failure.

Changes:

Bump Rust oxc* crates to 0.119.0 and Rust oxc_resolver* crates to 11.19.1.
Bump corresponding Node packages to 0.119.0 and refresh pnpm-lock.yaml.
Update compatibility test bookkeeping and refresh numerous snapshot fixtures for new codegen/minification output.

Reviewed changes

Copilot reviewed 48 out of 51 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pnpm-workspace.yaml	Bumps catalog versions for `@oxc-project/` and `oxc-` npm packages to `0.119.0`.
pnpm-lock.yaml	Lockfile refresh reflecting the upgraded Oxc-related npm packages.
packages/rollup-tests/src/status.json	Updates expected rollup test status counts after upgrade.
packages/rollup-tests/src/failed-tests.json	Adds `object-spread-side-effect` to known failing rollup tests.
packages/rolldown/tests/fixtures/builtin-plugin/import-glob/vite/virtual-modules/index.ts.snap	Updates Vite import-glob fixture snapshot for new output shape.
crates/rolldown_plugin_oxc_runtime/src/generated/embedded_helpers.rs	Updates embedded runtime helper prefix/version to `@oxc-project/runtime@0.119.0`.
crates/rolldown/tests/rollup/object-spread-side-effect/artifacts.snap	Snapshot update reflecting the current regression outcome.
crates/rolldown/tests/rollup/object-spread-side-effect/_config.json	Marks the fixture as `expectExecuted: false` to allow expected failure behavior.
crates/rolldown/tests/rolldown/tree_shaking/export_star/artifacts.snap	Snapshot update for changed tree-shaking/codegen output.
crates/rolldown/tests/rolldown/tree_shaking/commonjs_mixed/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/rolldown/tree_shaking/commonjs_inline_const_computed_key_write_object/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/rolldown/topics/keep_names/issue_7481_2/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/rolldown/topics/keep_names/if_stmt/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/rolldown/topics/deconflict/wrapped_esm_export_named_function/artifacts.snap	Snapshot update for changed mapping/output formatting.
crates/rolldown/tests/rolldown/topics/deconflict/wrapped_esm_default_function/artifacts.snap	Snapshot update for changed mapping/output formatting.
crates/rolldown/tests/rolldown/plugin/plugin_context/custom_arg_in_resolve/artifacts.snap	Snapshot update for updated CJS `require` handling output.
crates/rolldown/tests/rolldown/issues/5923/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/rolldown/issues/4472/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/rolldown/function/shim_missing_exports/basic_wrapped_esm/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/rolldown/function/module_types/issue-6345/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/rolldown/function/comments/annotation_false_with_treeshaking/artifacts.snap	Snapshot update for changed inlining/annotation handling.
crates/rolldown/tests/rolldown/cjs_compat/require/require_esm/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/rolldown/cjs_compat/esm_require_esm_unused/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/esbuild/ts/ts_export_missing_es6/artifacts.snap	Snapshot update for changed `__exportAll` inlining.
crates/rolldown/tests/esbuild/ts/ts_experimental_decorators_keep_names/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/esbuild/ts/export_type_issue379/artifacts.snap	Snapshot update for changed `__exportAll` inlining.
crates/rolldown/tests/esbuild/loader/require_custom_extension_string/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/esbuild/loader/require_custom_extension_data_url/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/esbuild/loader/require_custom_extension_base64/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/esbuild/loader/loader_file/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/esbuild/loader/auto_detect_mime_type_from_extension/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/esbuild/importstar_ts/ts_import_star_export_star_capture/artifacts.snap	Snapshot update for changed `__exportAll` inlining.
crates/rolldown/tests/esbuild/importstar_ts/ts_import_star_export_star_as_capture/artifacts.snap	Snapshot update for changed `__exportAll` inlining.
crates/rolldown/tests/esbuild/importstar_ts/ts_import_star_export_import_star_capture/artifacts.snap	Snapshot update for changed `__exportAll` inlining.
crates/rolldown/tests/esbuild/importstar_ts/ts_import_star_common_js_no_capture/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/esbuild/importstar_ts/ts_import_star_capture/artifacts.snap	Snapshot update for changed `__exportAll` inlining.
crates/rolldown/tests/esbuild/importstar/issue176/artifacts.snap	Snapshot update for changed `__exportAll` inlining.
crates/rolldown/tests/esbuild/default/top_level_await_forbidden_require_dead_branch/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/esbuild/default/top_level_await_forbidden_require/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/esbuild/default/require_txt/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/esbuild/default/require_json/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/esbuild/default/require_fs_browser/artifacts.snap	Snapshot update for updated CJS `require` handling output.
crates/rolldown/tests/esbuild/default/require_child_dir_common_js/artifacts.snap	Snapshot update for changed CommonJS wrapper inlining.
crates/rolldown/tests/esbuild/default/export_forms_common_js/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/esbuild/default/bundle_esm_with_nested_var_issue4348/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/esbuild/default/argument_default_value_scope_no_bundle/artifacts.snap	Snapshot update for codegen changes around hoisted `var` declarations.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_keep_bare_import_and_require_es6/artifacts.snap	Snapshot update for changed helper/codegen output.
crates/rolldown/tests/esbuild/dce/dce_of_symbol_instances/artifacts.snap	Snapshot update for changed DCE output.
Cargo.toml	Bumps Rust `oxc` crates to `0.119.0` and `oxc_resolver` to `11.19.1`.
Cargo.lock	Lockfile refresh for updated Rust dependencies.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

You can also share your feedback on Copilot code review. Take the survey.

packages/rolldown/tests/fixtures/builtin-plugin/import-glob/vite/virtual-modules/index.ts.snap

crates/rolldown/tests/rolldown/plugin/plugin_context/custom_arg_in_resolve/artifacts.snap

crates/rolldown/tests/esbuild/default/require_fs_browser/artifacts.snap

github-actions · 2026-03-14T12:14:54Z

Benchmarks Rust

target: main(795521b)
pr: upgrade-oxc-0.119.0(fe9150d)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     62.9±1.31ms        ? ?/sec    1.05     66.1±3.53ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     71.4±1.29ms        ? ?/sec    1.04     74.6±1.45ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    135.7±3.76ms        ? ?/sec    1.03    140.3±2.51ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    155.3±2.21ms        ? ?/sec    1.03    160.7±2.32ms        ? ?/sec
bundle/bundle@threejs                                        1.00     60.6±2.38ms        ? ?/sec    1.04     62.9±2.40ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     70.2±1.94ms        ? ?/sec    1.03     72.7±1.76ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    698.1±5.81ms        ? ?/sec    1.02    709.6±5.29ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    814.0±5.67ms        ? ?/sec    1.00    813.7±4.49ms        ? ?/sec
scan/scan@rome_ts                                            1.00     67.3±1.38ms        ? ?/sec    1.02     68.8±1.15ms        ? ?/sec
scan/scan@threejs                                            1.00     23.7±0.30ms        ? ?/sec    1.03     24.6±1.56ms        ? ?/sec
scan/scan@threejs10x                                         1.00    240.8±3.90ms        ? ?/sec    1.02    244.5±2.92ms        ? ?/sec

codspeed-hq · 2026-03-14T12:51:41Z

Merging this PR will improve performance by 3.14%

⚡ 1 improved benchmark
✅ 7 untouched benchmarks

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`scan@rome_ts`	374.9 ms	363.4 ms	+3.14%

_{Comparing upgrade-oxc-0.119.0 (fe9150d) with main (7b8c6ee)¹}

No successful run was found on main (795521b) during the generation of this report, so 7b8c6ee was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@IWANABETHATGUY

## [1.0.0-rc.10] - 2026-03-18 ### 🚀 Features - add indentExclusionRanges property to MagicString (#8746) by @IWANABETHATGUY - expose `oxcRuntimePlugin` (#8654) by @sapphi-red - rust: make bundler generic over FileSystem for in-memory benchmarks (#8652) by @Boshen ### 🐛 Bug Fixes - rolldown_plugin_vite_dynamic_import_vars: align dynamic import fast check with Vite (#8760) by @shulaoda - renamer: handle existing bindings in nested scopes when finding unique names (#8741) by @drewolson - pass `yarn_pnp` option where needed (#8736) by @sapphi-red - preserve optional chaining in namespace member expr rewrite (#8712) by @Copilot - correct UTF-16 index handling in native MagicString (#8693) by @IWANABETHATGUY - mark failing doctests as ignore (#8700) by @Boshen - prevent may_partial_namespace from leaking through include_module (#8682) by @IWANABETHATGUY - ci: bump native-build cache key to invalidate stale napi-rs artifacts (#8678) by @Boshen - `comments.annotation: false` breaking tree-shaking (#8657) by @IWANABETHATGUY - validate filenames for NUL bytes from chunkFileNames/entryFileNames (#8644) by @IWANABETHATGUY - dce-only minify should not set NODE_ENV to production (#8651) by @IWANABETHATGUY ### 🚜 Refactor - rust: remove dead `CrossModuleOptimizationConfig::side_effects_free_function_optimization` (#8673) by @Dunqing - rust: simplify `cross_module_optimization` by removing redundant scope tracking (#8672) by @Dunqing - simplify string repeat in guess_indentor (#8753) by @IWANABETHATGUY - consolidate custom magic-string tests into one file (#8696) by @IWANABETHATGUY - extract CJS bailout checks from include_symbol (#8683) by @IWANABETHATGUY - rust: remove `BindingIdentifierExt` to use `BindingIdentifier::symbol_id()` instead (#8667) by @Dunqing - bench: add bench_preset helper and inline presets (#8658) by @Boshen - rust: filter external modules from entries instead of mapping bit positions (#8637) by @Dunqing ### 📚 Documentation - clarify watch mode behavior and its limitations (#8751) by @sapphi-red - add external link icon to GitHub button in Hero section (#8731) by @thisisnkc - guide: clarify that `inject` option is only conceptually similar to esbuild's one (#8743) by @sapphi-red - meta/design: add `devtools.md` (#8663) by @hyf0 - add viteplus alpha announcement banner (#8668) by @shulaoda ### ⚡ Performance - rolldown: some minor perf optimization found by autoresearch (#8730) by @Brooooooklyn - replace Vec allocation with lazy iterator in find_hash_placeholders (#8703) by @Boshen - replace TypedDashMap with TypedMap in CustomField (#8708) by @Boshen - bench: remove scan benchmark binary to halve LTO link time (#8694) by @Boshen ### 🧪 Testing - watch: increase timeout for error output (#8766) by @sapphi-red - vite-tests: remove JS plugin tests (#8767) by @sapphi-red - watch: add CLI exit code test (#8752) by @sapphi-red - normalize paths on Windows even if `resolve.symlinks` is false (#8483) by @sapphi-red ### ⚙️ Miscellaneous Tasks - correct comment in bundle-analyzer-plugin.ts (#8770) by @origami-z - upgrade oxc to 0.120.0 (#8764) by @Boshen - enable all test for `reset` category in MagicString.test.ts (#8749) by @IWANABETHATGUY - deps: update test262 submodule for tests (#8742) by @sapphi-red - deps: update oxc apps (#8734) by @renovate[bot] - deps: update softprops/action-gh-release action to v2.6.1 (#8724) by @renovate[bot] - deps: update npm packages (major) (#8722) by @renovate[bot] - deps: update github-actions (major) (#8721) by @renovate[bot] - deps: update softprops/action-gh-release action to v2.6.0 (#8720) by @renovate[bot] - deps: update npm packages (#8718) by @renovate[bot] - deps: update rust crates (#8717) by @renovate[bot] - deps: update github-actions (#8716) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.17.0 (#8713) by @renovate[bot] - deps: bump cargo-shear to v1.11.2 (#8711) by @Boshen - use org level `CODE_OF_CONDUCT.md` (#8706) by @sapphi-red - fix cache key mismatch and remove redundant cache saves (#8695) by @Boshen - deps: update oxc apps (#8692) by @renovate[bot] - deps: update oxc apps (#8649) by @renovate[bot] - should do matrix out side of reusable workflows 2 (#8691) by @hyf0 - should do matrix out side of reusable workflows (#8690) by @hyf0 - deps: update dependency rolldown-plugin-dts to v0.22.5 (#8689) by @renovate[bot] - upgrade oxc to 0.119.0 and oxc_resolver to 11.19.1 (#8686) by @Boshen - correct if condition of `type-check` job (#8677) by @hyf0 - Gate CI type-check job on node changes (#8669) by @Copilot - benchmark: improve codspeed build (#8665) by @Boshen - deps: update oxc to v0.118.0 (#8650) by @renovate[bot] - deps: update crate-ci/typos action to v1.44.0 (#8647) by @renovate[bot] - deps: update oxc resolver to v11.19.1 (#8646) by @renovate[bot] - deps: update dependency rust to v1.94.0 (#8648) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.22.4 (#8645) by @renovate[bot] ### ◀️ Revert - Revert "ci: Gate CI type-check job on node changes" (#8674) by @hyf0 - "chore(deps): update dependency rust to v1.94.0 (#8648)" (#8660) by @shulaoda ### ❤️ New Contributors * @origami-z made their first contribution in [#8770](#8770) * @drewolson made their first contribution in [#8741](#8741) * @thisisnkc made their first contribution in [#8731](#8731) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 14, 2026 11:49

github-actions bot assigned Boshen Mar 14, 2026

Copilot started reviewing on behalf of Boshen March 14, 2026 11:49 View session

chatgpt-codex-connector bot reviewed Mar 14, 2026

View reviewed changes

crates/rolldown/tests/rollup/object-spread-side-effect/_config.json Show resolved Hide resolved

Boshen force-pushed the upgrade-oxc-0.119.0 branch from d9a9dae to 62ac53e Compare March 14, 2026 11:54

Boshen force-pushed the upgrade-oxc-0.119.0 branch from 62ac53e to fe9150d Compare March 14, 2026 11:57

Copilot AI reviewed Mar 14, 2026

View reviewed changes

Boshen merged commit 8dff16b into main Mar 14, 2026
35 checks passed

Boshen deleted the upgrade-oxc-0.119.0 branch March 14, 2026 12:12

This was referenced Mar 18, 2026

release: v1.0.0-rc.10 #8759

Closed

release: v1.0.0-rc.10 #8774

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade oxc to 0.119.0 and oxc_resolver to 11.19.1#8686

chore: upgrade oxc to 0.119.0 and oxc_resolver to 11.19.1#8686
Boshen merged 1 commit intomainfrom
upgrade-oxc-0.119.0

Boshen commented Mar 14, 2026

Uh oh!

socket-security bot commented Mar 14, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 14, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

codspeed-hq bot commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Boshen commented Mar 14, 2026

Summary

Uh oh!

socket-security bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2026

Benchmarks Rust

Uh oh!

codspeed-hq bot commented Mar 14, 2026

Merging this PR will improve performance by 3.14%

Performance Changes

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

socket-security bot commented Mar 14, 2026 •

edited

Loading

netlify bot commented Mar 14, 2026 •

edited

Loading