fix(rolldown_plugin_vite_dynamic_import_vars): align dynamic import fast check with Vite by shulaoda · Pull Request #8760 · rolldown/rolldown

shulaoda · 2026-03-18T01:06:59Z

closes vitejs/vite#21855, related to https://github.com/vitejs/vite/blob/40bc7293/packages/vite/src/node/plugins/dynamicImportVars.ts#L30-L33

shulaoda · 2026-03-18T01:07:13Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-03-18T01:07:17Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`2268c8b`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69ba268ccfdd800008213de4
😎 Deploy Preview	https://deploy-preview-8760--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-03-18T01:22:08Z

Benchmarks Rust

target: main(64db202)
pr: 03-18-fix_rolldown_plugin_vite_dynamic_import_vars_align_dynamic_import_fast_check_with_vite(2268c8b)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     63.2±1.57ms        ? ?/sec    1.00     63.3±1.23ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     70.9±1.44ms        ? ?/sec    1.01     71.5±1.58ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    137.4±3.20ms        ? ?/sec    1.01    138.6±3.28ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    156.5±3.04ms        ? ?/sec    1.00    157.1±3.41ms        ? ?/sec
bundle/bundle@threejs                                        1.02     60.8±3.33ms        ? ?/sec    1.00     59.6±0.83ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     70.4±1.71ms        ? ?/sec    1.00     69.5±1.57ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    692.2±3.86ms        ? ?/sec    1.01    696.0±5.10ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    792.2±4.56ms        ? ?/sec    1.00    794.0±5.22ms        ? ?/sec

codspeed-hq · 2026-03-18T01:31:15Z

Merging this PR will not alter performance

✅ 6 untouched benchmarks
⏩ 8 skipped benchmarks¹

_{Comparing 03-18-fix_rolldown_plugin_vite_dynamic_import_vars_align_dynamic_import_fast_check_with_vite (2268c8b) with main (2bfe619)²}

8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (64db202) during the generation of this report, so 2bfe619 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

sapphi-red

Would you add a test?

…ast check with Vite

...fixtures/builtin-plugin/dynamic-import-vars/import-with-comment/with-comment-before-paren.js

…-vars/import-with-comment/with-comment-before-paren.js Co-authored-by: 翠 <green@sapphi.red> Signed-off-by: dalaoshu <165626830+shulaoda@users.noreply.github.com>

@IWANABETHATGUY

## [1.0.0-rc.10] - 2026-03-18 ### 🚀 Features - add indentExclusionRanges property to MagicString (#8746) by @IWANABETHATGUY - expose `oxcRuntimePlugin` (#8654) by @sapphi-red - rust: make bundler generic over FileSystem for in-memory benchmarks (#8652) by @Boshen ### 🐛 Bug Fixes - rolldown_plugin_vite_dynamic_import_vars: align dynamic import fast check with Vite (#8760) by @shulaoda - renamer: handle existing bindings in nested scopes when finding unique names (#8741) by @drewolson - pass `yarn_pnp` option where needed (#8736) by @sapphi-red - preserve optional chaining in namespace member expr rewrite (#8712) by @Copilot - correct UTF-16 index handling in native MagicString (#8693) by @IWANABETHATGUY - mark failing doctests as ignore (#8700) by @Boshen - prevent may_partial_namespace from leaking through include_module (#8682) by @IWANABETHATGUY - ci: bump native-build cache key to invalidate stale napi-rs artifacts (#8678) by @Boshen - `comments.annotation: false` breaking tree-shaking (#8657) by @IWANABETHATGUY - validate filenames for NUL bytes from chunkFileNames/entryFileNames (#8644) by @IWANABETHATGUY - dce-only minify should not set NODE_ENV to production (#8651) by @IWANABETHATGUY ### 🚜 Refactor - rust: remove dead `CrossModuleOptimizationConfig::side_effects_free_function_optimization` (#8673) by @Dunqing - rust: simplify `cross_module_optimization` by removing redundant scope tracking (#8672) by @Dunqing - simplify string repeat in guess_indentor (#8753) by @IWANABETHATGUY - consolidate custom magic-string tests into one file (#8696) by @IWANABETHATGUY - extract CJS bailout checks from include_symbol (#8683) by @IWANABETHATGUY - rust: remove `BindingIdentifierExt` to use `BindingIdentifier::symbol_id()` instead (#8667) by @Dunqing - bench: add bench_preset helper and inline presets (#8658) by @Boshen - rust: filter external modules from entries instead of mapping bit positions (#8637) by @Dunqing ### 📚 Documentation - clarify watch mode behavior and its limitations (#8751) by @sapphi-red - add external link icon to GitHub button in Hero section (#8731) by @thisisnkc - guide: clarify that `inject` option is only conceptually similar to esbuild's one (#8743) by @sapphi-red - meta/design: add `devtools.md` (#8663) by @hyf0 - add viteplus alpha announcement banner (#8668) by @shulaoda ### ⚡ Performance - rolldown: some minor perf optimization found by autoresearch (#8730) by @Brooooooklyn - replace Vec allocation with lazy iterator in find_hash_placeholders (#8703) by @Boshen - replace TypedDashMap with TypedMap in CustomField (#8708) by @Boshen - bench: remove scan benchmark binary to halve LTO link time (#8694) by @Boshen ### 🧪 Testing - watch: increase timeout for error output (#8766) by @sapphi-red - vite-tests: remove JS plugin tests (#8767) by @sapphi-red - watch: add CLI exit code test (#8752) by @sapphi-red - normalize paths on Windows even if `resolve.symlinks` is false (#8483) by @sapphi-red ### ⚙️ Miscellaneous Tasks - correct comment in bundle-analyzer-plugin.ts (#8770) by @origami-z - upgrade oxc to 0.120.0 (#8764) by @Boshen - enable all test for `reset` category in MagicString.test.ts (#8749) by @IWANABETHATGUY - deps: update test262 submodule for tests (#8742) by @sapphi-red - deps: update oxc apps (#8734) by @renovate[bot] - deps: update softprops/action-gh-release action to v2.6.1 (#8724) by @renovate[bot] - deps: update npm packages (major) (#8722) by @renovate[bot] - deps: update github-actions (major) (#8721) by @renovate[bot] - deps: update softprops/action-gh-release action to v2.6.0 (#8720) by @renovate[bot] - deps: update npm packages (#8718) by @renovate[bot] - deps: update rust crates (#8717) by @renovate[bot] - deps: update github-actions (#8716) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.17.0 (#8713) by @renovate[bot] - deps: bump cargo-shear to v1.11.2 (#8711) by @Boshen - use org level `CODE_OF_CONDUCT.md` (#8706) by @sapphi-red - fix cache key mismatch and remove redundant cache saves (#8695) by @Boshen - deps: update oxc apps (#8692) by @renovate[bot] - deps: update oxc apps (#8649) by @renovate[bot] - should do matrix out side of reusable workflows 2 (#8691) by @hyf0 - should do matrix out side of reusable workflows (#8690) by @hyf0 - deps: update dependency rolldown-plugin-dts to v0.22.5 (#8689) by @renovate[bot] - upgrade oxc to 0.119.0 and oxc_resolver to 11.19.1 (#8686) by @Boshen - correct if condition of `type-check` job (#8677) by @hyf0 - Gate CI type-check job on node changes (#8669) by @Copilot - benchmark: improve codspeed build (#8665) by @Boshen - deps: update oxc to v0.118.0 (#8650) by @renovate[bot] - deps: update crate-ci/typos action to v1.44.0 (#8647) by @renovate[bot] - deps: update oxc resolver to v11.19.1 (#8646) by @renovate[bot] - deps: update dependency rust to v1.94.0 (#8648) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.22.4 (#8645) by @renovate[bot] ### ◀️ Revert - Revert "ci: Gate CI type-check job on node changes" (#8674) by @hyf0 - "chore(deps): update dependency rust to v1.94.0 (#8648)" (#8660) by @shulaoda ### ❤️ New Contributors * @origami-z made their first contribution in [#8770](#8770) * @drewolson made their first contribution in [#8741](#8741) * @thisisnkc made their first contribution in [#8731](#8731) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned shulaoda Mar 18, 2026

shulaoda requested a review from sapphi-red March 18, 2026 01:08

shulaoda marked this pull request as ready for review March 18, 2026 01:08

shulaoda added the test: vite-tests Trigger Vite tests workflow on this PR label Mar 18, 2026

sapphi-red reviewed Mar 18, 2026

View reviewed changes

shulaoda marked this pull request as draft March 18, 2026 03:05

shulaoda force-pushed the 03-18-fix_rolldown_plugin_vite_dynamic_import_vars_align_dynamic_import_fast_check_with_vite branch from e453387 to 87b1350 Compare March 18, 2026 03:22

shulaoda marked this pull request as ready for review March 18, 2026 03:22

shulaoda marked this pull request as draft March 18, 2026 03:24

fix(rolldown_plugin_vite_dynamic_import_vars): align dynamic import f…

b36918f

…ast check with Vite

shulaoda force-pushed the 03-18-fix_rolldown_plugin_vite_dynamic_import_vars_align_dynamic_import_fast_check_with_vite branch from 87b1350 to b36918f Compare March 18, 2026 03:25

shulaoda marked this pull request as ready for review March 18, 2026 03:31

shulaoda requested a review from sapphi-red March 18, 2026 03:31

sapphi-red reviewed Mar 18, 2026

View reviewed changes

...fixtures/builtin-plugin/dynamic-import-vars/import-with-comment/with-comment-before-paren.js Outdated Show resolved Hide resolved

Update packages/rolldown/tests/fixtures/builtin-plugin/dynamic-import…

2268c8b

…-vars/import-with-comment/with-comment-before-paren.js Co-authored-by: 翠 <green@sapphi.red> Signed-off-by: dalaoshu <165626830+shulaoda@users.noreply.github.com>

sapphi-red approved these changes Mar 18, 2026

View reviewed changes

shulaoda merged commit 25d11c9 into main Mar 18, 2026
32 checks passed

shulaoda deleted the 03-18-fix_rolldown_plugin_vite_dynamic_import_vars_align_dynamic_import_fast_check_with_vite branch March 18, 2026 04:31

github-actions bot mentioned this pull request Mar 18, 2026

release: v1.0.0-rc.10 #8774

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rolldown_plugin_vite_dynamic_import_vars): align dynamic import fast check with Vite#8760

fix(rolldown_plugin_vite_dynamic_import_vars): align dynamic import fast check with Vite#8760
shulaoda merged 2 commits intomainfrom
03-18-fix_rolldown_plugin_vite_dynamic_import_vars_align_dynamic_import_fast_check_with_vite

shulaoda commented Mar 18, 2026 •

edited

Loading

Uh oh!

shulaoda commented Mar 18, 2026

Uh oh!

netlify bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

sapphi-red left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

shulaoda commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Mar 18, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

codspeed-hq bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shulaoda commented Mar 18, 2026 •

edited

Loading

netlify bot commented Mar 18, 2026 •

edited

Loading

github-actions bot commented Mar 18, 2026 •

edited

Loading

codspeed-hq bot commented Mar 18, 2026 •

edited

Loading