Skip to content

docs: add format option to directives example config#8590

Merged
shulaoda merged 1 commit intomainfrom
03-09-docs_add_format_option_to_directives_example_config
Mar 9, 2026
Merged

docs: add format option to directives example config#8590
shulaoda merged 1 commit intomainfrom
03-09-docs_add_format_option_to_directives_example_config

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Mar 8, 2026

The config example sets output.strict: true but doesn’t set output.format. Since output.format defaults to 'es', this example won’t actually emit a "use strict" directive (ESM is always strict and Rolldown doesn’t output the directive). Consider setting a non-ES format (e.g. 'cjs') in the example, or explicitly stating that the example assumes a non-ES output format.

  output: {
    format: 'cjs',

Originally posted by @copilot in #8535

Copy link
Member Author

shulaoda commented Mar 8, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title docs: add format option to directives example config docs: add format option to directives example config Mar 8, 2026
@shulaoda shulaoda marked this pull request as ready for review March 8, 2026 16:21
Copilot AI review requested due to automatic review settings March 8, 2026 16:21
@netlify
Copy link

netlify bot commented Mar 8, 2026

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit b8ed511
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69ada1f2746e880008f67844
😎 Deploy Preview https://deploy-preview-8590--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the directives documentation example so that output.strict: true is demonstrated in a configuration where Rolldown can actually emit a top-level "use strict" directive (i.e., non-ES output format).

Changes:

  • Set output.format: 'cjs' in the output.strict example config to avoid the default 'es' format case where no "use strict" directive is emitted.

@shulaoda shulaoda merged commit 934e0c0 into main Mar 9, 2026
52 of 54 checks passed
@shulaoda shulaoda deleted the 03-09-docs_add_format_option_to_directives_example_config branch March 9, 2026 02:11
@github-actions github-actions bot mentioned this pull request Mar 9, 2026
shulaoda added a commit that referenced this pull request Mar 9, 2026
## [1.0.0-rc.8] - 2026-03-09

### 🚀 Features

- watch: enable full functional fs watcher in wasm (#8575) by @hyf0
- watch: expose debounce related options (#8572) by @hyf0

### 🐛 Bug Fixes

- detect new URL(…, import.meta.url) with no-sub template literal (#8565) by @char
- devtools: trace dynamic imports in devtools (#8581) by @cal-gooo
- watch: rebuild when a previously missing file is created (#8562) by @hyf0-agent
- watch: filter out Access events to prevent infinite rebuild loop on Linux (#8557) by @hyf0-agent

### 🚜 Refactor

- watch: remove auto watch for fail imports (#8585) by @hyf0
- fs_watcher: unify the way of constructing watcher (#8571) by @hyf0
- cli: migrate CLI to CAC (#8551) by @h-a-n-a
- switch asset module support from hard-code to builtin plugin (#8546) by @hyf0

### 📚 Documentation

- fix subject-verb agreement in why-bundlers.md (#8591) by @brandonzylstra
- maintenance: align release and canary workflow guide (#8538) by @minsoo-web
- add `format` option to directives example config (#8590) by @shulaoda
- fix: change twitter to x logo in team (#8552) by @mdong1909
- correct composable filter support explanation (#8550) by @sapphi-red

### ⚡ Performance

- testing: share tokio runtime across fixture tests (#8567) by @Boshen

### 🧪 Testing

- hmr: fix infinite loop in dev server test retry logic (#8576) by @hyf0-agent
- cli: add more cli-e2e test cases (#8548) by @h-a-n-a

### ⚙️ Miscellaneous Tasks

- docs: update in-depth/directives for `output.strict` option (#8535) by @minsoo-web
- add PNPM_HOME Dev Drive mapping to Windows CI workflows (#8589) by @Boshen
- deps: update github-actions (#8588) by @renovate[bot]
- move Windows cargo target dir to Dev Drive (#8586) by @Boshen
- optimize cache keys to fix race conditions and reduce usage (#8578) by @Boshen
- remove WASI build & test pipeline (#8580) by @Boshen
- remove unnecessary submodule checkouts (#8577) by @Boshen
- use Dev Drive for Windows CI jobs (#8574) by @Boshen
- skip redundant native binding build for browser and remove standalone job (#8573) by @Boshen
- parallelize Node tests on ubuntu, single Node 24 on macOS/windows (#8570) by @Boshen
- docs: bump @voidzero-dev/vitepress-theme to 4.8.0 (#8558) by @crusty-voidzero
- dedupe type-check from dev server workflow (#8554) by @Boshen

### ❤️ New Contributors

* @brandonzylstra made their first contribution in [#8591](#8591)
* @char made their first contribution in [#8565](#8565)
* @cal-gooo made their first contribution in [#8581](#8581)
* @hyf0-agent made their first contribution in [#8562](#8562)
* @h-a-n-a made their first contribution in [#8551](#8551)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants