Skip to content

docs: correct composable filter support explanation#8550

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-05-docs_correct_composable_filter_support_explanation
Mar 5, 2026
Merged

docs: correct composable filter support explanation#8550
graphite-app[bot] merged 1 commit intomainfrom
03-05-docs_correct_composable_filter_support_explanation

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 5, 2026

It doesn't work in Vite 7, Vite 8, rolldown-vite.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review March 5, 2026 10:35
Copilot AI review requested due to automatic review settings March 5, 2026 10:35
@netlify
Copy link

netlify bot commented Mar 5, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a97e1d0
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69a963da7351d100088c6adf

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the documentation for composable filter support, removing outdated references to "legacy Vite" and "Vite Beta" and clarifying that composable filters are only supported in Rolldown plugins (not in Vite 7, Vite 8, rolldown-vite, or unplugin).

Changes:

  • Updated the warning in packages/pluginutils/README.md to reflect accurate support status for composable filters.
  • Updated the identical warning in docs/apis/plugin-api/hook-filters.md for consistency.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/pluginutils/README.md Corrects composable filters warning: removes "legacy Vite"/"Vite Beta" distinction, limits support claim to Rolldown only
docs/apis/plugin-api/hook-filters.md Same warning correction for consistency across documentation

Copy link
Member Author

sapphi-red commented Mar 5, 2026

Merge activity

  • Mar 5, 10:42 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 5, 11:06 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Mar 5, 11:16 AM UTC: Merged by the Graphite merge queue.

@IWANABETHATGUY
Copy link
Member

may i ask why? IIRC, rolldown-vite reuse rolldown plugin system under the hood.

It doesn't work in Vite 7, Vite 8, rolldown-vite.
@graphite-app graphite-app bot force-pushed the 03-05-docs_correct_composable_filter_support_explanation branch from e6546ff to a97e1d0 Compare March 5, 2026 11:07
@shulaoda
Copy link
Member

shulaoda commented Mar 5, 2026

may i ask why? IIRC, rolldown-vite reuse rolldown plugin system under the hood.

I thought that is because rolldown-vite latest version doesn't depend on latest rolldown version.

@sapphi-red
Copy link
Member Author

It's because the dev server doesn't use Rolldown's plugin pipeline and it's not implemented there.

@graphite-app graphite-app bot merged commit a97e1d0 into main Mar 5, 2026
31 of 32 checks passed
@graphite-app graphite-app bot deleted the 03-05-docs_correct_composable_filter_support_explanation branch March 5, 2026 11:16
@IWANABETHATGUY
Copy link
Member

It's because the dev server doesn't use Rolldown's plugin pipeline and it's not implemented there.

Ah, that makes sense. I only verified the composable filter with Vite build before updating the doc last time.

@github-actions github-actions bot mentioned this pull request Mar 9, 2026
shulaoda added a commit that referenced this pull request Mar 9, 2026
## [1.0.0-rc.8] - 2026-03-09

### 🚀 Features

- watch: enable full functional fs watcher in wasm (#8575) by @hyf0
- watch: expose debounce related options (#8572) by @hyf0

### 🐛 Bug Fixes

- detect new URL(…, import.meta.url) with no-sub template literal (#8565) by @char
- devtools: trace dynamic imports in devtools (#8581) by @cal-gooo
- watch: rebuild when a previously missing file is created (#8562) by @hyf0-agent
- watch: filter out Access events to prevent infinite rebuild loop on Linux (#8557) by @hyf0-agent

### 🚜 Refactor

- watch: remove auto watch for fail imports (#8585) by @hyf0
- fs_watcher: unify the way of constructing watcher (#8571) by @hyf0
- cli: migrate CLI to CAC (#8551) by @h-a-n-a
- switch asset module support from hard-code to builtin plugin (#8546) by @hyf0

### 📚 Documentation

- fix subject-verb agreement in why-bundlers.md (#8591) by @brandonzylstra
- maintenance: align release and canary workflow guide (#8538) by @minsoo-web
- add `format` option to directives example config (#8590) by @shulaoda
- fix: change twitter to x logo in team (#8552) by @mdong1909
- correct composable filter support explanation (#8550) by @sapphi-red

### ⚡ Performance

- testing: share tokio runtime across fixture tests (#8567) by @Boshen

### 🧪 Testing

- hmr: fix infinite loop in dev server test retry logic (#8576) by @hyf0-agent
- cli: add more cli-e2e test cases (#8548) by @h-a-n-a

### ⚙️ Miscellaneous Tasks

- docs: update in-depth/directives for `output.strict` option (#8535) by @minsoo-web
- add PNPM_HOME Dev Drive mapping to Windows CI workflows (#8589) by @Boshen
- deps: update github-actions (#8588) by @renovate[bot]
- move Windows cargo target dir to Dev Drive (#8586) by @Boshen
- optimize cache keys to fix race conditions and reduce usage (#8578) by @Boshen
- remove WASI build & test pipeline (#8580) by @Boshen
- remove unnecessary submodule checkouts (#8577) by @Boshen
- use Dev Drive for Windows CI jobs (#8574) by @Boshen
- skip redundant native binding build for browser and remove standalone job (#8573) by @Boshen
- parallelize Node tests on ubuntu, single Node 24 on macOS/windows (#8570) by @Boshen
- docs: bump @voidzero-dev/vitepress-theme to 4.8.0 (#8558) by @crusty-voidzero
- dedupe type-check from dev server workflow (#8554) by @Boshen

### ❤️ New Contributors

* @brandonzylstra made their first contribution in [#8591](#8591)
* @char made their first contribution in [#8565](#8565)
* @cal-gooo made their first contribution in [#8581](#8581)
* @hyf0-agent made their first contribution in [#8562](#8562)
* @h-a-n-a made their first contribution in [#8551](#8551)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants