ci: optimize cache keys to fix race conditions and reduce usage#8578
Merged
ci: optimize cache keys to fix race conditions and reduce usage#8578
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes GitHub Actions cache usage by replacing the shared debug-build cache key with per-job-type keys, adding save-cache guards to only save on main branch pushes, disabling caching for release and metric builds, and removing the now-unnecessary cache-warmup.yml workflow.
Changes:
- Assign unique cache keys per job type (
lint,cargo-test,native-build,wasi-build) instead of sharing a singledebug-buildkey, and addsave-cacheguards to limit saves tomainbranch pushes only. - Disable cache restore/save for release builds (
reusable-release-build.yml) and metric builds (metric.yml) to prevent cache poisoning and wasted I/O. - Delete
cache-warmup.ymlwhich was warming caches across all 3 OS unnecessarily.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Update rust-validation to lint key and node-validation to native-build key; add save-cache guards |
.github/workflows/reusable-cargo-test.yml |
Change cache key from debug-build to cargo-test; add save-cache guard |
.github/workflows/reusable-native-build.yml |
Change cache key from debug-build to native-build; add save-cache guard |
.github/workflows/reusable-wasi-build.yml |
Change cache key from debug-build-wasi to wasi-build; add save-cache guard |
.github/workflows/vite-tests.yml |
Change cache key from debug-build to native-build; add save-cache guard |
.github/workflows/reusable-release-build.yml |
Replace per-target cache keys with restore-cache: false for build-binding and build-rolldown-browser |
.github/workflows/metric.yml |
Add restore-cache: false since cargo clean immediately follows |
.github/workflows/cache-warmup.yml |
Deleted; cache warming is now handled by save-cache guards on individual jobs |
f13419b to
0c24c8d
Compare
bda460c to
929465e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3a3088f1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hyf0
approved these changes
Mar 8, 2026
2c458ba to
0a64abb
Compare
Assign correct cache keys per job type instead of sharing `debug-build` across all jobs, which caused race conditions where the first job to finish saved a partial cache. Remove the `cache-warmup.yml` workflow that wasted space on unused OS/target combinations. Disable caching for release builds to prevent cache poisoning. Skip cache restore for metric job since it does `cargo clean` immediately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- metric.yml: remove `cache-key` (dead with `restore-cache: false`), add `save-cache: false` to prevent unnecessary cache writes that could collide with benchmark-node.yml - reusable-release-build.yml: change build-rolldown-debug from `cache-key: debug-build` to `restore-cache: false` for consistency with sibling release build jobs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- reusable-release-build.yml: add explicit `save-cache: false` alongside `restore-cache: false` to fully disable caching for release builds - copilot-setup-steps.yml: update orphaned `debug-build` key to `lint` - update-test-dependencies.yml: update orphaned `debug-build` key to `native-build` and add `save-cache: false` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
metric.yml does `cargo build --release` so it shouldn't share the `release-build` key with benchmark-node.yml. Give it a dedicated `metric` key and allow saving (on main only, via setup-rust default). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
0a64abb to
aeedd63
Compare
Closed
Merged
shulaoda
added a commit
that referenced
this pull request
Mar 9, 2026
## [1.0.0-rc.8] - 2026-03-09 ### 🚀 Features - watch: enable full functional fs watcher in wasm (#8575) by @hyf0 - watch: expose debounce related options (#8572) by @hyf0 ### 🐛 Bug Fixes - detect new URL(…, import.meta.url) with no-sub template literal (#8565) by @char - devtools: trace dynamic imports in devtools (#8581) by @cal-gooo - watch: rebuild when a previously missing file is created (#8562) by @hyf0-agent - watch: filter out Access events to prevent infinite rebuild loop on Linux (#8557) by @hyf0-agent ### 🚜 Refactor - watch: remove auto watch for fail imports (#8585) by @hyf0 - fs_watcher: unify the way of constructing watcher (#8571) by @hyf0 - cli: migrate CLI to CAC (#8551) by @h-a-n-a - switch asset module support from hard-code to builtin plugin (#8546) by @hyf0 ### 📚 Documentation - fix subject-verb agreement in why-bundlers.md (#8591) by @brandonzylstra - maintenance: align release and canary workflow guide (#8538) by @minsoo-web - add `format` option to directives example config (#8590) by @shulaoda - fix: change twitter to x logo in team (#8552) by @mdong1909 - correct composable filter support explanation (#8550) by @sapphi-red ### ⚡ Performance - testing: share tokio runtime across fixture tests (#8567) by @Boshen ### 🧪 Testing - hmr: fix infinite loop in dev server test retry logic (#8576) by @hyf0-agent - cli: add more cli-e2e test cases (#8548) by @h-a-n-a ### ⚙️ Miscellaneous Tasks - docs: update in-depth/directives for `output.strict` option (#8535) by @minsoo-web - add PNPM_HOME Dev Drive mapping to Windows CI workflows (#8589) by @Boshen - deps: update github-actions (#8588) by @renovate[bot] - move Windows cargo target dir to Dev Drive (#8586) by @Boshen - optimize cache keys to fix race conditions and reduce usage (#8578) by @Boshen - remove WASI build & test pipeline (#8580) by @Boshen - remove unnecessary submodule checkouts (#8577) by @Boshen - use Dev Drive for Windows CI jobs (#8574) by @Boshen - skip redundant native binding build for browser and remove standalone job (#8573) by @Boshen - parallelize Node tests on ubuntu, single Node 24 on macOS/windows (#8570) by @Boshen - docs: bump @voidzero-dev/vitepress-theme to 4.8.0 (#8558) by @crusty-voidzero - dedupe type-check from dev server workflow (#8554) by @Boshen ### ❤️ New Contributors * @brandonzylstra made their first contribution in [#8591](#8591) * @char made their first contribution in [#8565](#8565) * @cal-gooo made their first contribution in [#8581](#8581) * @hyf0-agent made their first contribution in [#8562](#8562) * @h-a-n-a made their first contribution in [#8551](#8551) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache-warmup.yml— was warming caches across all 3 OS unnecessarily, wasting ~3 GB of cache spacedebug-buildacross all jobs, which caused race conditions where the first job to finish saved a partial cache:rust-validation→lint(ubuntu only)cargo-test→cargo-test(3 OS)reusable-native-build/node-validation/vite-tests→native-build(3 OS)reusable-wasi-build→wasi-build(ubuntu only)save-cacheguards — only save cache onmainbranch pushesrestore-cache: falseonreusable-release-build.yml(includingbuild-rolldown-browserandbuild-rolldown-debug) to prevent cache poisoning in published artifactsmetric.yml— it doescargo cleanimmediately, so restoring/saving is wasted I/O and could collide withbenchmark-node.yml'srelease-buildcacheEstimated total cache usage drops from ~9.9 GB to ~6.4 GB, well within the 10 GB limit.
🤖 Generated with Claude Code