feat(watch): enable full functional fs watcher in wasm by hyf0 · Pull Request #8575 · rolldown/rolldown

hyf0 · 2026-03-07T06:22:53Z

Not if this helps #8563 but might be related.

hyf0 · 2026-03-07T06:23:09Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-03-07T06:44:18Z

Benchmarks Rust

target: 03-07-feat_watch_expose_debounce_related_options(461527b)
pr: 03-07-feat_watch_enable_full_functional_fs_watcher_in_wasm(6c50eac)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     77.6±1.59ms        ? ?/sec    1.01     78.3±1.87ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     86.2±3.61ms        ? ?/sec    1.00     86.0±2.05ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    159.9±3.65ms        ? ?/sec    1.00    160.2±3.18ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    176.5±2.69ms        ? ?/sec    1.00    177.1±3.35ms        ? ?/sec
bundle/bundle@threejs                                        1.00     71.7±0.93ms        ? ?/sec    1.02     73.2±3.43ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     78.2±1.21ms        ? ?/sec    1.00     78.3±1.46ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    769.3±8.58ms        ? ?/sec    1.00    771.5±8.17ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    879.0±6.63ms        ? ?/sec    1.02   898.8±11.23ms        ? ?/sec
scan/scan@rome_ts                                            1.01     77.4±1.51ms        ? ?/sec    1.00     76.5±1.31ms        ? ?/sec
scan/scan@threejs                                            1.00     27.4±1.71ms        ? ?/sec    1.00     27.5±1.78ms        ? ?/sec
scan/scan@threejs10x                                         1.00    263.0±2.59ms        ? ?/sec    1.01    265.7±2.77ms        ? ?/sec

Copilot

Pull request overview

Enables using the real filesystem watcher implementation in WASM/WASI builds (instead of falling back to a noop watcher), primarily by removing wasm-specific gating in the watcher factory and its supporting utilities, and updating the underlying rolldown-notify* dependencies.

Changes:

Switch rolldown_watcher to always construct an FS watcher via create_fs_watcher (removing the wasm noop fallback).
Make debouncer adapter utilities and watcher implementations build on wasm targets by removing cfg(not(target_family = "wasm")) gating.
Bump rolldown-notify / rolldown-notify-debouncer-full dependency versions and refresh the lockfile.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/rolldown_watcher/src/watcher.rs	Removes wasm-only noop watcher path; always uses `create_fs_watcher` for task watchers.
crates/rolldown_fs_watcher/src/utils.rs	Makes debouncer adapter available unconditionally (incl. wasm).
crates/rolldown_fs_watcher/src/lib.rs	Removes wasm gating; exposes polling/debounced watcher selection for wasm as well.
crates/rolldown_fs_watcher/Cargo.toml	Makes debouncer dependency unconditional (not target-gated).
Cargo.toml	Bumps `rolldown-notify` and `rolldown-notify-debouncer-full` versions.
Cargo.lock	Updates resolved dependency graph accordingly (incl. transitive bumps).

crates/rolldown_watcher/src/watcher.rs

graphite-app · 2026-03-08T05:07:23Z

Merge activity

Mar 8, 5:07 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Mar 8, 5:24 AM UTC: Merged by the Graphite merge queue.

Not if this helps #8563 but might be related.

@hyf0

## [1.0.0-rc.8] - 2026-03-09 ### 🚀 Features - watch: enable full functional fs watcher in wasm (#8575) by @hyf0 - watch: expose debounce related options (#8572) by @hyf0 ### 🐛 Bug Fixes - detect new URL(…, import.meta.url) with no-sub template literal (#8565) by @char - devtools: trace dynamic imports in devtools (#8581) by @cal-gooo - watch: rebuild when a previously missing file is created (#8562) by @hyf0-agent - watch: filter out Access events to prevent infinite rebuild loop on Linux (#8557) by @hyf0-agent ### 🚜 Refactor - watch: remove auto watch for fail imports (#8585) by @hyf0 - fs_watcher: unify the way of constructing watcher (#8571) by @hyf0 - cli: migrate CLI to CAC (#8551) by @h-a-n-a - switch asset module support from hard-code to builtin plugin (#8546) by @hyf0 ### 📚 Documentation - fix subject-verb agreement in why-bundlers.md (#8591) by @brandonzylstra - maintenance: align release and canary workflow guide (#8538) by @minsoo-web - add `format` option to directives example config (#8590) by @shulaoda - fix: change twitter to x logo in team (#8552) by @mdong1909 - correct composable filter support explanation (#8550) by @sapphi-red ### ⚡ Performance - testing: share tokio runtime across fixture tests (#8567) by @Boshen ### 🧪 Testing - hmr: fix infinite loop in dev server test retry logic (#8576) by @hyf0-agent - cli: add more cli-e2e test cases (#8548) by @h-a-n-a ### ⚙️ Miscellaneous Tasks - docs: update in-depth/directives for `output.strict` option (#8535) by @minsoo-web - add PNPM_HOME Dev Drive mapping to Windows CI workflows (#8589) by @Boshen - deps: update github-actions (#8588) by @renovate[bot] - move Windows cargo target dir to Dev Drive (#8586) by @Boshen - optimize cache keys to fix race conditions and reduce usage (#8578) by @Boshen - remove WASI build & test pipeline (#8580) by @Boshen - remove unnecessary submodule checkouts (#8577) by @Boshen - use Dev Drive for Windows CI jobs (#8574) by @Boshen - skip redundant native binding build for browser and remove standalone job (#8573) by @Boshen - parallelize Node tests on ubuntu, single Node 24 on macOS/windows (#8570) by @Boshen - docs: bump @voidzero-dev/vitepress-theme to 4.8.0 (#8558) by @crusty-voidzero - dedupe type-check from dev server workflow (#8554) by @Boshen ### ❤️ New Contributors * @brandonzylstra made their first contribution in [#8591](#8591) * @char made their first contribution in [#8565](#8565) * @cal-gooo made their first contribution in [#8581](#8581) * @hyf0-agent made their first contribution in [#8562](#8562) * @h-a-n-a made their first contribution in [#8551](#8551) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

github-actions bot assigned hyf0 Mar 7, 2026

hyf0 mentioned this pull request Mar 7, 2026

refactor(fs_watcher): unify the way of constructing watcher #8571

Merged

hyf0 mentioned this pull request Mar 7, 2026

feat(watch): expose debounce related options #8572

Merged

hyf0 force-pushed the 03-07-feat_watch_expose_debounce_related_options branch from e6a3fcc to ee41cb9 Compare March 7, 2026 06:25

hyf0 force-pushed the 03-07-feat_watch_enable_full_functional_fs_watcher_in_wasm branch from 7d38817 to 788cab4 Compare March 7, 2026 06:25

hyf0 marked this pull request as ready for review March 7, 2026 06:26

hyf0 requested review from Copilot, sapphi-red and shulaoda and removed request for Copilot March 7, 2026 06:26

Copilot started reviewing on behalf of hyf0 March 7, 2026 06:26 View session

Copilot AI review requested due to automatic review settings March 7, 2026 06:45

hyf0 force-pushed the 03-07-feat_watch_enable_full_functional_fs_watcher_in_wasm branch from 788cab4 to 6fd8418 Compare March 7, 2026 06:45

Copilot started reviewing on behalf of hyf0 March 7, 2026 06:45 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

crates/rolldown_watcher/src/watcher.rs Show resolved Hide resolved

shulaoda approved these changes Mar 7, 2026

View reviewed changes

sapphi-red approved these changes Mar 7, 2026

View reviewed changes

graphite-app bot force-pushed the 03-07-feat_watch_expose_debounce_related_options branch 2 times, most recently from 3634b05 to 461527b Compare March 7, 2026 10:32

graphite-app bot force-pushed the 03-07-feat_watch_enable_full_functional_fs_watcher_in_wasm branch from 6fd8418 to 6c50eac Compare March 7, 2026 10:32

hyf0 added the graphite: merge-when-ready label Mar 8, 2026

graphite-app bot force-pushed the 03-07-feat_watch_expose_debounce_related_options branch from 461527b to 83ad228 Compare March 8, 2026 05:07

graphite-app bot pushed a commit that referenced this pull request Mar 8, 2026

feat(watch): enable full functional fs watcher in wasm (#8575)

ce2243e

Not if this helps #8563 but might be related.

graphite-app bot force-pushed the 03-07-feat_watch_enable_full_functional_fs_watcher_in_wasm branch from 6c50eac to ce2243e Compare March 8, 2026 05:08

feat(watch): enable full functional fs watcher in wasm (#8575)

19b8db0

Not if this helps #8563 but might be related.

graphite-app bot force-pushed the 03-07-feat_watch_expose_debounce_related_options branch from 83ad228 to ea76147 Compare March 8, 2026 05:15

graphite-app bot force-pushed the 03-07-feat_watch_enable_full_functional_fs_watcher_in_wasm branch from ce2243e to 19b8db0 Compare March 8, 2026 05:16

Base automatically changed from 03-07-feat_watch_expose_debounce_related_options to main March 8, 2026 05:22

graphite-app bot removed the graphite: merge-when-ready label Mar 8, 2026

graphite-app bot merged commit 19b8db0 into main Mar 8, 2026
32 checks passed

graphite-app bot deleted the 03-07-feat_watch_enable_full_functional_fs_watcher_in_wasm branch March 8, 2026 05:24

hyf0 added the graphite: merge-when-ready label Mar 8, 2026

sapphi-red mentioned this pull request Mar 8, 2026

feat: enable watcher in wasi build #8563

Closed

github-actions bot mentioned this pull request Mar 9, 2026

release: v1.0.0-rc.8 #8592

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(watch): enable full functional fs watcher in wasm#8575

feat(watch): enable full functional fs watcher in wasm#8575
graphite-app[bot] merged 1 commit intomainfrom
03-07-feat_watch_enable_full_functional_fs_watcher_in_wasm

hyf0 commented Mar 7, 2026 •

edited

Loading

Uh oh!

hyf0 commented Mar 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Mar 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hyf0 commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyf0 commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

graphite-app bot commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hyf0 commented Mar 7, 2026 •

edited

Loading

hyf0 commented Mar 7, 2026 •

edited

Loading

github-actions bot commented Mar 7, 2026 •

edited

Loading

graphite-app bot commented Mar 8, 2026 •

edited

Loading