test(cli): add more cli-e2e test cases#8548
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
8051f50 to
bc9bf0f
Compare
bc9bf0f to
044d84d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional CLI end-to-end (Vitest) coverage for help/version output, unknown option handling, and config-vs-CLI precedence, plus supporting fixtures and documentation for an upcoming CLI parser refactor.
Changes:
- Add new CLI e2e test cases (
--help/-h,--version/-v, unrecognized options warning, CLI overriding config). - Add a
test:cliscript and new fixture for config override behavior. - Add a CLI refactor design doc outlining migration from
parseArgstocac.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
test262 |
Updates the test262 submodule pointer. |
packages/rolldown/tests/package.json |
Adds a dedicated test:cli script to run the CLI e2e tests. |
packages/rolldown/tests/cli/fixtures/cli-override-config/rolldown.config.js |
Adds a fixture config used to assert CLI options override config values. |
packages/rolldown/tests/cli/fixtures/cli-override-config/index.ts |
Adds a minimal input module for the override-config fixture. |
packages/rolldown/tests/cli/cli-e2e.test.ts |
Adds new CLI e2e assertions + refactors stdout normalization for snapshots. |
packages/rolldown/tests/cli/__snapshots__/cli-e2e.test.ts.snap |
Updates snapshots for new help and module-types test coverage. |
meta/design/cli.md |
Adds a design doc for future CLI refactor to cac. |
hyf0
reviewed
Mar 6, 2026
hyf0
reviewed
Mar 6, 2026
hyf0
reviewed
Mar 6, 2026
hyf0
reviewed
Mar 6, 2026
hyf0
reviewed
Mar 6, 2026
hyf0
approved these changes
Mar 6, 2026
Member
hyf0
left a comment
There was a problem hiding this comment.
LGTM. It's fine to merge it. Please resolve comments and check if they make sense before continuing the merge.
IWANABETHATGUY
approved these changes
Mar 6, 2026
Member
Author
|
Refer to the second PR for the finalized design doc #8551 |
044d84d to
427a798
Compare
427a798 to
84f4f79
Compare
Contributor
Merge activity
|
## New CLI e2e test cases - `--version` and `-v` - `--help` and `-h` - Unrecognized options warn but do not error - CLI options override config values (`--format cjs` overrides config `format: "esm"`) ## Other - Add `test:cli` script to `packages/rolldown/tests/package.json` - Add design doc `meta/design/cli.md` for CLI refactor (#8410) ## Design doc Refer to the second PR for the finalized design doc #8551 Design doc in the PR is just used for migration.
84f4f79 to
80fcfea
Compare
Merged
shulaoda
added a commit
that referenced
this pull request
Mar 9, 2026
## [1.0.0-rc.8] - 2026-03-09 ### 🚀 Features - watch: enable full functional fs watcher in wasm (#8575) by @hyf0 - watch: expose debounce related options (#8572) by @hyf0 ### 🐛 Bug Fixes - detect new URL(…, import.meta.url) with no-sub template literal (#8565) by @char - devtools: trace dynamic imports in devtools (#8581) by @cal-gooo - watch: rebuild when a previously missing file is created (#8562) by @hyf0-agent - watch: filter out Access events to prevent infinite rebuild loop on Linux (#8557) by @hyf0-agent ### 🚜 Refactor - watch: remove auto watch for fail imports (#8585) by @hyf0 - fs_watcher: unify the way of constructing watcher (#8571) by @hyf0 - cli: migrate CLI to CAC (#8551) by @h-a-n-a - switch asset module support from hard-code to builtin plugin (#8546) by @hyf0 ### 📚 Documentation - fix subject-verb agreement in why-bundlers.md (#8591) by @brandonzylstra - maintenance: align release and canary workflow guide (#8538) by @minsoo-web - add `format` option to directives example config (#8590) by @shulaoda - fix: change twitter to x logo in team (#8552) by @mdong1909 - correct composable filter support explanation (#8550) by @sapphi-red ### ⚡ Performance - testing: share tokio runtime across fixture tests (#8567) by @Boshen ### 🧪 Testing - hmr: fix infinite loop in dev server test retry logic (#8576) by @hyf0-agent - cli: add more cli-e2e test cases (#8548) by @h-a-n-a ### ⚙️ Miscellaneous Tasks - docs: update in-depth/directives for `output.strict` option (#8535) by @minsoo-web - add PNPM_HOME Dev Drive mapping to Windows CI workflows (#8589) by @Boshen - deps: update github-actions (#8588) by @renovate[bot] - move Windows cargo target dir to Dev Drive (#8586) by @Boshen - optimize cache keys to fix race conditions and reduce usage (#8578) by @Boshen - remove WASI build & test pipeline (#8580) by @Boshen - remove unnecessary submodule checkouts (#8577) by @Boshen - use Dev Drive for Windows CI jobs (#8574) by @Boshen - skip redundant native binding build for browser and remove standalone job (#8573) by @Boshen - parallelize Node tests on ubuntu, single Node 24 on macOS/windows (#8570) by @Boshen - docs: bump @voidzero-dev/vitepress-theme to 4.8.0 (#8558) by @crusty-voidzero - dedupe type-check from dev server workflow (#8554) by @Boshen ### ❤️ New Contributors * @brandonzylstra made their first contribution in [#8591](#8591) * @char made their first contribution in [#8565](#8565) * @cal-gooo made their first contribution in [#8581](#8581) * @hyf0-agent made their first contribution in [#8562](#8562) * @h-a-n-a made their first contribution in [#8551](#8551) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New CLI e2e test cases
--versionand-v--helpand-h--format cjsoverrides configformat: "esm")Other
test:cliscript topackages/rolldown/tests/package.jsonmeta/design/cli.mdfor CLI refactor (Using CLI framework to replace current rawparseArgs#8410)Design doc
Refer to the second PR for the finalized design doc #8551
Design doc in the PR is just used for migration.