forked from DynamoDS/Dynamo
-
Notifications
You must be signed in to change notification settings - Fork 0
Update from DynamoDS repo #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revit element selection nodes should serialize and deserialize properly in Json
Make '=' be optional in return statement
QNTM-1476: Upload JSON files to S3
Revert "Make '=' be optional in return statement"
Update two failed test cases
Fix compilation error for language block in non-assignment statement
Not allow function overloads which only diff in parameters' ranks
Ensure empty selection nodes serialize/deserialize properly
# Conflicts: # src/Libraries/Watch3DNodeModelsWpf/HelixWatch3DNodeViewModel.cs # src/Libraries/Watch3DNodeModelsWpf/Watch3DNodeViewCustomization.cs
QNTM-2446 Rename select UI nodes to provide distinction from ZT nodes
The tests have now passed twice in a row after the latest change. - merging this in.
check for null if the watch3dnode is not created correctly
Remove icons from Geometry class sub-categories
Updated missing protogeometry icons and ones with typos in the name. Cone.ByCoordinateSystemHeightRadius.Small Cylinder.Axis Cylinder.Height
Updating protogeometry icons
Restore Curve.SplitByParameter, Geometry.SerializeAsSAB, and Polysurface.BySweep Icons
Update libraryItems.json
* Add Engine reference to workspace writer converter. * Pass workspace to get updated copy of connectors collection. * UpdateLibrarie * Update resources * Update Library and add resources
Update LibrarieJS
Adding new icons for DateTime.Format and FileSystem.AppendText
New 2.0 Icons
* Remove non-integer indexing of arrays * Fix nuget changes to csproj, packages * DSDictionary * Fix bug * Reverse errant comment refactoring step 1 * Fix errant refactorings * Fix another errant refactoring * More refactoring reversals * More cleanup * Fix various failed refactors * Reverse filename refactoring * Fix refactoring mistake * Fix another refactoring mistake * Dictionary library * Stub out DictionaryNode * Fix bugs in unmarshaling code * Dictionary2 - A Dictionary type implemented with System.Collections.Immutable * Dictionary -> FunctionCall, various bugs * Generate function call for Dictionary init * Correctly handle Dictionary2 type in CompactBubbleHandler * Remove builtin Dictionary helper type * Rename Dictionary2 to Dictionary * Cleanup in DictionaryNode * ValueAtKey * Attempt to handle array lookup as function call * Cleanup Dictionary preview and disable some broken code * Hack indexing into parser * Clean up cargo cult crap in Dictionary.cs * Get rid of more cargo cult crap * Hacky parser support * Making parser slightly less hacky * Some more cleanup * Dictionaries only allow string keys, separate file for Builtin * Convenience method for indexing * Update csproj files for new file * Remove failed attempt at DSDictionary, everything is zero touch * Revert a bunch of unrelated changes * DictionaryExpressionBuilder instead of DictionaryNode * Separate CollectionMarshaler into DictionaryMarshaler * Fix some minor FFI, preview bubble bugs, make things a bit easier to refactor * Cleanup, document associative AST * Fix mistaken deletion * Handle a[0..10] = 2; style initialization of arrays * Update atg file for parser change * Some convenience methods for working with Dictionaries done to avoid working on harder problems :) * Minor naming tweaks to Dictionary * Update FunctionCallNodeController * Re-add FunctionObject.ds code, DictionaryExpression in imperative code first steps * Update Parser, minor changes to AST * Handle index expression lookup in ImperativeAST * Update BuiltIn.xml * Update CoreNodes.csproj * Delete packages.config * Update BuiltinMethodsTest.cs * minor fixes * fixed parser for new Dictionary use in functionobject.ds * parser updates * fix crash while compiling function object DS scripts * more fixes for compilation of function object DS scripts * fix to for loops * refactor Builtin.Get * fix for function objects to work with dictionaries * correct line and column info for ValueAtIndex AST * marshaler fixes for C# Dictionaries * fix warning message * Dictionary category placement in Library UI * fix parser to accept identifiers in dictionary initialization * update tests * update tests * fix tests * update tests * revert unchanged files * update more tests * parser fix, test updates * categorize failing tests * fix infinite loop while indexing empty lists * fix for AST creation for multi-output NodeModel nodes * updated List tests * update more tests * mark looping test under failure category * fix custom node definition compilation for multi-outputs * fix custom node test * updated ValueAtIndex for lists for arbitrary inputs for indices * change ValueAtIndex to accept arbitrary lists of keys * reverting changes to ValueAtIndex, marking infinite test as category:failure * fix for codegen of replication guides with identifier lists * fixed parsing issues with replication guides, updated tests * updated ATG files, added missing DYN for test * deleted obsolete test, deferred tests by marking under failure category * tag failing element rewriter tests to address later
radumg
pushed a commit
that referenced
this pull request
Oct 5, 2018
* First steps on test rewrites * Fix potential parser bug * More work on rewrite * More rewrite progress * A few more steps * Debug rewrite seems about right * Enable for all tests * A few more steps * Rewrite tests for array syntax change * Fix bug in rewriter * Revert "Rewrite tests for array syntax change" This reverts commit f9798c9. * Don't touch files with no arrays * Rewrite tests rev2 * Ugh tabs * Remove rewriter code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.