Skip to content

Update LibrarieJS #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ramramps merged 1 commit into from
Dec 13, 2017
Merged

Update LibrarieJS #8397

ramramps merged 1 commit into from
Dec 13, 2017

Conversation

@ramramps
Copy link
Collaborator

@ramramps ramramps commented Dec 13, 2017 •
edited
Loading

Purpose

This PR is to update LibrarieJS. classType is a new elementType added to LibraryViewTypes. This is in sync with LibrarieJS

Related LibrarieJS PR: DynamoDS/librarie.js#111

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@QilongTang

@ramramps ramramps mentioned this pull request Dec 13, 2017
Merged
@QilongTang
Copy link
Contributor

QilongTang commented Dec 13, 2017

LGTM

@ramramps ramramps merged commit 7e4bb11 into DynamoDS:master Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ramramps @QilongTang