Skip to content

Conversation

@ke-yu
Copy link
Contributor

@ke-yu ke-yu commented Sep 5, 2017

Purpose

The following two return styles are both supported.

def foo() {
    return 6;
}

def bar() {
    return = 6;
}

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@aparajit-pratap

FYIs

@kronz @Racel

@aparajit-pratap
Copy link
Contributor

Thanks @ke-yu LGTM!

@ke-yu ke-yu merged commit 929820a into DynamoDS:master Sep 6, 2017
aparajit-pratap added a commit that referenced this pull request Sep 6, 2017
* minor code cleanup

* fix tests
@aparajit-pratap
Copy link
Contributor

@ke-yu this still doesn't fix the issue below :(

screen shot 2017-08-31 at 4 42 46 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants