Skip to content

New 2.0 Icons #8400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Racel merged 1 commit into from
Dec 15, 2017
Merged

New 2.0 Icons #8400

Racel merged 1 commit into from
Dec 15, 2017

Conversation

@Racel
Copy link
Contributor

@Racel Racel commented Dec 14, 2017 •
edited
Loading

Purpose

Adding new icons for DateTime.Format and FileSystem.AppendText

JIRA: https://jira.autodesk.com/browse/QNTM-2458

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@alfarok

@Racel
New 2.0 Icons
4640fd6 
Adding new icons for DateTime.Format and FileSystem.AppendText
@Racel Racel requested a review from alfarok December 14, 2017 16:50
@alfarok
Copy link
Contributor

alfarok commented Dec 15, 2017

@Racel Looks like the test cases you added are passing, LGTM
image

@Racel
Copy link
Contributor Author

Racel commented Dec 15, 2017

Great! Merging this then.

@Racel Racel merged commit ff91ac6 into master Dec 15, 2017
@QilongTang QilongTang deleted the New2.0Icons branch January 23, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alfarok alfarok Awaiting requested review from alfarok

Assignees

@alfarok alfarok

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Racel @alfarok