Skip to content

Conversation

@alfarok
Copy link
Contributor

@alfarok alfarok commented Dec 9, 2017

Purpose

Addition to PR-8386
Icon Test was failing because the libraryItems.json was not updated after removing overloads and updating icon names. I also removed some old icons that are no longer used, hence the .resx changes.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@alfarok alfarok merged commit ca6ea56 into DynamoDS:master Dec 9, 2017
@mjkkirschner
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants