Skip to content

Conversation

@alfarok
Copy link
Contributor

@alfarok alfarok commented Dec 8, 2017

Purpose

Related to:
DYN-857

The purpose of this PR is to restore Curve.SplitByParameter , Geometry.SerializeAsSAB , and Polysurface.BySweep icons. Both of these nodes originally had overloads but have more recently been consolidated into single nodes. I have also removed the old icons that are no longer used.

image

image

image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@Racel
@mjkkirschner

@alfarok alfarok added the PTAL Please Take A Look 👀 label Dec 8, 2017
@alfarok alfarok changed the title Restore Curve.SplitByParameter and Geometry.SerializeAsSAB Icons Restore Curve.SplitByParameter, Geometry.SerializeAsSAB, and Polysurface.BySweep Icons Dec 8, 2017
@Racel
Copy link
Contributor

Racel commented Dec 8, 2017

@alfarok - Icons look right! Thanks!

@alfarok alfarok merged commit eae6a70 into DynamoDS:master Dec 8, 2017
@alfarok alfarok mentioned this pull request Dec 9, 2017
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PTAL Please Take A Look 👀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants