Ensure empty selection nodes serialize/deserialize properly #8166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This should have been included w/ PR-8131. I realized the bug when testing D4R UI node deserilazation in the current task.
If a selection node is added to the graph with no selection that graph would serialize the
InstanceIDproperty asnull. This would cause the node to not deserialization properly due to the missing property and it would never be added to the graph when reopening. This PR initializesInstanceIDw/ an empty list to avoid thenullvalue.I also verified all the RTF selection tests still pass with this change but we may want to add additional testing to catch this behavior in the future.
To reproduce:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang
FYIs
@smangarole